683988 - Event is accepted even though Cancel is selected on calendar choice popup

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Eric Tiffany]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0.1) Gecko/20100101 Firefox/6.0.1
Build ID: 20110830092941

Steps to reproduce:

I had three calendars active:  Local, Caldav1, Caldav2

I clicked Accept on an invitation in mail, and selected the Local calendar from the dialog, clicked OK.  The event was created.  I then deleted the event in the Lightning calendar.  Went back to mail and clicked Accept.  This time I clicked Cancel, but the event was accepted anyway and added to the Local calendar.  

I disabled the Local calendar and repeated the experiment.  When I click Accept, the calendar choice dialog shows Caldav1 and Caldav2. When I click Cancel on the calendar choice dialog, the event is accepted


Actual results:

The event was created even though I clicked cancel on the calendar dialog


Expected results:

The event should not have been created.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

Confirmed, fixed. We didn't ignore processing if no target calendar is set. Most of these changes are whitespace changes, the only real change was in promptCalendar to return a value if no calendar is selected and in executeAction to ignore the rest if false was returned.

Comment 2

[Matthew Mecca [:mmecca]]

Comment on attachment 560687 [details] [diff] [review]
Fix - v1

Review of attachment 560687 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=mmecca

::: calendar/lightning/content/imip-bar.js
@@ +180,3 @@
>  
> +                    if (!Components.isSuccessCode(aStatus)) {
> +                      showError(label);

minor nit - indent is only 2 spaces.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/02df7fdfbf98>
-> FIXED

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-aurora <http://hg.mozilla.org/releases/comm-aurora/rev/3fb86c930b20>

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-beta <http://hg.mozilla.org/releases/comm-beta/rev/ecfbbd376228>