683998 - GCC 4.6 build warning: "jstracer.cpp:17174:20: warning: variable 'v' set but not used [-Wunused-but-set-variable]"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

Filing bug on this GCC 4.6 build warning:
js/src/jstracer.cpp:17174:20: warning: variable 'v' set but not used [-Wunused-but-set-variable]

Here's the chunk of code, quoted from the cset that added it (for bug 606650):
>   1.134 +    } else if (op == JSOP_AND) {
>   1.135 +        bool b = !!js_ValueToBoolean(cx->regs->sp[-1]);
>   1.136 +        StackValue v = stackAt(-1);
>   1.137 +        if (b)
>   1.138 +            stackPop();
>   1.139 +    } else {
https://hg.mozilla.org/mozilla-central/rev/81fa7d0b8f00#l1.134

Looks indeed like |v| is unused there (and I assume (?) the stackAt(-1) call doesn't have any side effects that need to take place).

So, I think that line (marked 1.136 above) can simply be deleted.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix: remove unused variable

Comment 2

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3959615183f6

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/3959615183f6