684037 - IonMonkey: Assert building SSA finding target of break in while

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

This is failing on ecma_2/Statements/while-004.js.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Note, this patch just changes the assert to a compilation-abort. This case seems extremely rare, and we'd need to add more information to the bytecode to parse it in our current algorithm.

Comment 3

[Sean Stangl [:sstangl]]

Comment on attachment 557718 [details] [diff] [review]
fix

Review of attachment 557718 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/IonBuilder.cpp
@@ +1009,5 @@
> +        // single-level break is actually 5. To recognize this case we'd need
> +        // to know about the label structure at 0,5 ahead of time - and lacking
> +        // those source notes for now, we just abort instead.
> +        abort("could not find the target of a break");
> +        return ControlStatus_Error;

This is fine, but we should plan to handle the case eventually. Can a different bug be filed for this, with its number referenced in a comment here?

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/projects/ionmonkey/rev/834f8ff1748e

Filed bug 684384.