684107 - Remove private browsing code from DownloadLastDir.jsm after bug 679784 is fixed

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect)

Description

[Geoff Lankow (:darktrojan)]

I'll fix this once bug 679784 lands on m-c, unless someone beats me to it.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: patch

Comment 2

[(no longer active)]

Comment on attachment 558054 [details] [diff] [review]
patch

Looks great!

Comment 3

[(no longer active)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e80b7fe1c11c

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/e80b7fe1c11c

Comment 5

[:Gavin Sharp [email: [e-mail]]]

looks like this forgot to remove the import() for Dict.jsm.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: followup patch to remove unused imports

(In reply to Gavin Sharp (use [e-mail] for email) from comment #5)
> looks like this forgot to remove the import() for Dict.jsm.

And XPCOMUtils.jsm, which is interesting because it wasn't ever used here. :/

Comment 7

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ccf407f0b85

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6ccf407f0b85