684130 - Fix or drop support for cygwin python

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Mark Hammond [:markh] [:mhammond]]

There seem to be a number of issues using a cygwin python with the addon-sdk on Windows.  I personally can't even get it started, but while helping someone on IRC who could get it started reports the output I've pasted below.

We should either drop support for cygwin (and ideally have cfx.bat detect if it is being used and report a nice error) or fix it.

$ /cygdrive/c/openwebapps/deps/addon-sdk/bin/cfx test
cygwin warning:
  MS-DOS style path detected: C:\Program Files (x86)/Mozilla Firefox/firefox.exe
  Preferred POSIX equivalent is: /cygdrive/c/Program Files (x86)/Mozilla Firefox
/firefox.exe
  CYGWIN environment variable option "nodosfilewarning" turns off this warning.
  Consult the user's guide for more details about POSIX paths:
    http://cygwin.com/cygwin-ug-net/using.html#using-pathnames
Using binary at 'C:\Program Files (x86)/Mozilla Firefox/firefox.exe'.
Using profile at '/tmp/tmpxJkyX2.mozrunner'.
Traceback (most recent call last):
  File "/cygdrive/c/openwebapps/deps/addon-sdk/bin/cfx", line 29, in <module>
    cuddlefish.run()
  File "/cygdrive/c/openwebapps/deps/addon-sdk/python-lib/cuddlefish/__init__.py", line 783, in run
    norun=options.no_run)
  File "/cygdrive/c/openwebapps/deps/addon-sdk/python-lib/cuddlefish/runner.py", line 326, in run_app
    runner.stop()
  File "/cygdrive/c/openwebapps/deps/addon-sdk/python-lib/mozrunner/__init__.py", line 472, in stop
    self.kill()
  File "/cygdrive/c/openwebapps/deps/addon-sdk/python-lib/mozrunner/__init__.py", line 458, in kill
    for pid in get_pids(name, self.process_handler.pid):
  File "/cygdrive/c/openwebapps/deps/addon-sdk/python-lib/mozrunner/__init__.py", line 110, in get_pids
    import wpk
  File "/cygdrive/c/openwebapps/deps/addon-sdk/python-lib/mozrunner/wpk.py", line 1, in <module>
    from ctypes import sizeof, windll, addressof, c_wchar, create_unicode_buffer

ImportError: cannot import name windll

Comment 1

[Myk Melez [:myk] [@mykmelez]]

If someone was willing to own Cygwin support, then I would happily accept patches to make it work.  Failing that, I think we should drop support for it, because we don't have the time to support more Windows environments than we already do.

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Sorry we won't be releasing any new versions of cfx, jpm is the replacement https://www.npmjs.com/package/jpm