Shutdown crash reporting exception [@ nsTHashtable<nsBaseHashtableET<nsUint64HashKey, nsGlobalWindow*> >::GetEntry ]

RESOLVED FIXED in mozilla9

Status

()

Core
DOM
--
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

({crash})

Trunk
mozilla9
x86_64
Linux
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Created attachment 557740 [details]
stack

While shutting down, I crashed today trying to report an exception (see the attached stack). What appears to have happened is that during shutdown some sort of "race" in an extension I have caused an exception to be thrown from an nsITimer callback. Reporting the exception in XPConnect tries to get the inner window from the inner window ID. However, we're already far enough into shutdown that the call to nsGlobalWindow::GetInnerWindowWithId crashes because we've already nulled out nsGlobalWindow::sWindowsById.
(Assignee)

Comment 1

6 years ago
Created attachment 557745 [details] [diff] [review]
patch v1

I can see a few ways of fixing this: add the null check here or in nsScriptError or check that we're in shutdown somehow in nsScriptError. I don't have a strong opinion for any of the options though.

I haven't been able to reproduce the crash since the first time, sadly.
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #557745 - Flags: review?(bzbarsky)
Comment on attachment 557745 [details] [diff] [review]
patch v1

r=me
Attachment #557745 - Flags: review?(bzbarsky) → review+

Comment 3

6 years ago
http://hg.mozilla.org/mozilla-central/rev/d06e88a99f39
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Severity: normal → critical
Crash Signature: [@ nsTHashtable<nsBaseHashtableET<nsUint64HashKey, nsGlobalWindow*> >::GetEntry ]
Keywords: crash
You need to log in before you can comment on or make changes to this bug.