684178 - jsfiddle.net throws error selectionRange is not defined in nightly 09/01

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Cork]

The edit fields doesn't work in jsfiddle

Reproducible: Always

Steps to Reproduce:
 1. Open jsfiddle
 2. Look in error console

Actual Results:  
The edit fields is empty and ins't editable
Error console shows
  Error: selectionRange is not defined
  Source File: http://jsfiddle.net/codemirror/js/select.js
  Line: 631

Expected Results:  
The top two and the left field should be editable.

Regression range:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f1dbc0a63703&tochange=9eaca4ef5880

Comment 1

[Boris Zbarsky [:bzbarsky]]

Requesting tracking for the regression.

Cork, can you narrow down which of those changesets is causing the problem?

Comment 2

[Cork]

It's caused by http://hg.mozilla.org/integration/mozilla-inbound/rev/9eaca4ef5880

Comment 3

[Jason Orendorff [:jorendorff]]

Oh, great, it has to do with local function declarations. Reduced:

var obj = {};
(function() {
    if (obj) {
        function f() {}
        obj.m = function() { f(); };
    }
})();
obj.m();

Comment 4

[Jason Orendorff [:jorendorff]]

The outer, anonymous function is heavyweight, so the inner lambda should not be a null closure, much less qualify for the method optimization, but:

00000:  name "obj"
00003:  ifeq 21 (+18)
00006:  deffun function f() {}
00009:  nullblockchain
00010:  name "obj"
00013:  lambda (function () {f();})
00016:  nullblockchain                   <--- wrong
00017:  setmethod "m"                    <--- seriously wrong
00020:  pop
00021:  stop

Comment 5

[Jason Orendorff [:jorendorff]]

Attachment: v1

This r? would go to Waldo if he were around.

Comment 6

[Jeff Walden [:Waldo]]

Comment on attachment 557954 [details] [diff] [review]
v1

Review of attachment 557954 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing per jorendorff's request, looks reasonable.

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/6b384ab36161

Comment 9

[Cork]

Verified fixed in Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110911 Firefox/9.0a1