jsfiddle.net throws error selectionRange is not defined in nightly 09/01

VERIFIED FIXED in mozilla9

Status

()

Core
JavaScript Engine
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Cork, Assigned: jorendorff)

Tracking

({regression})

Trunk
mozilla9
regression
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox9+)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
The edit fields doesn't work in jsfiddle

Reproducible: Always

Steps to Reproduce:
 1. Open jsfiddle
 2. Look in error console

Actual Results:  
The edit fields is empty and ins't editable
Error console shows
  Error: selectionRange is not defined
  Source File: http://jsfiddle.net/codemirror/js/select.js
  Line: 631

Expected Results:  
The top two and the left field should be editable.

Regression range:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f1dbc0a63703&tochange=9eaca4ef5880
(Reporter)

Updated

6 years ago
(Reporter)

Updated

6 years ago
Keywords: regression
Requesting tracking for the regression.

Cork, can you narrow down which of those changesets is causing the problem?
tracking-firefox9: --- → ?
tracking-firefox9: ? → +
(Reporter)

Comment 2

6 years ago
It's caused by http://hg.mozilla.org/integration/mozilla-inbound/rev/9eaca4ef5880
Blocks: 561359
(Assignee)

Updated

6 years ago
Assignee: general → jorendorff
(Assignee)

Comment 3

6 years ago
Oh, great, it has to do with local function declarations. Reduced:

var obj = {};
(function() {
    if (obj) {
        function f() {}
        obj.m = function() { f(); };
    }
})();
obj.m();
(Assignee)

Comment 4

6 years ago
The outer, anonymous function is heavyweight, so the inner lambda should not be a null closure, much less qualify for the method optimization, but:

00000:  name "obj"
00003:  ifeq 21 (+18)
00006:  deffun function f() {}
00009:  nullblockchain
00010:  name "obj"
00013:  lambda (function () {f();})
00016:  nullblockchain                   <--- wrong
00017:  setmethod "m"                    <--- seriously wrong
00020:  pop
00021:  stop
(Assignee)

Comment 5

6 years ago
Created attachment 557954 [details] [diff] [review]
v1

This r? would go to Waldo if he were around.
Attachment #557954 - Flags: review?(cdleary)
Comment on attachment 557954 [details] [diff] [review]
v1

Review of attachment 557954 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing per jorendorff's request, looks reasonable.
Attachment #557954 - Flags: review?(cdleary) → review+
http://hg.mozilla.org/mozilla-central/rev/6b384ab36161
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla9

Updated

6 years ago
Duplicate of this bug: 685864
(Reporter)

Comment 9

6 years ago
Verified fixed in Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110911 Firefox/9.0a1
Status: RESOLVED → VERIFIED

Updated

6 years ago
Duplicate of this bug: 684779

Updated

6 years ago
Duplicate of this bug: 684972
You need to log in before you can comment on or make changes to this bug.