Closed
Bug 684225
Opened 13 years ago
Closed 13 years ago
Removal of locally stored attachments should be done from Attachment.pm
Categories
(Bugzilla :: Attachments & Requests, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.4
People
(Reporter: c1541, Assigned: c1541)
Details
Attachments
(1 file)
|
1.03 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0
Build ID: 20110824172139
Expected results:
In attachment.cgi, delete_attachment sub there is some code to remove locally stored attachments.
This should be moved into Attachment.pm, remove_from_db so that the code is more modular.
Attachment #557936 -
Flags: review?
Attachment #557936 -
Flags: review? → review?(LpSolit)
|
||
Updated•13 years ago
|
Assignee: general → attach-and-request
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Component: Bugzilla-General → Attachments & Requests
Ever confirmed: true
Target Milestone: --- → Bugzilla 5.0
|
||
Comment 2•13 years ago
|
||
Ah, this duplicates some work that is being done in another patch (the one about only storing text attachments in the database).
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 557936 [details] [diff] [review]
Move unlink code from cgi to pm
r=LpSolit
Attachment #557936 -
Flags: review?(LpSolit) → review+
|
|
||
Comment 4•13 years ago
|
||
As we have no API which can delete attachments yet, there is no need to take this patch for 4.2.
Assignee: attach-and-request → c1541
Status: NEW → ASSIGNED
Flags: approval+
|
|
||
Comment 5•13 years ago
|
||
And thanks to the reporter for the patch. :) I modified it slightly to match what mkanat did in bug 577532.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified attachment.cgi
modified Bugzilla/Attachment.pm
Committed revision 8037.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•