User Agent: Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0 Build ID: 20110824172139 Expected results: In attachment.cgi, delete_attachment sub there is some code to remove locally stored attachments. This should be moved into Attachment.pm, remove_from_db so that the code is more modular.
Created attachment 557936 [details] [diff] [review] Move unlink code from cgi to pm
Attachment #557936 - Flags: review?
Assignee: general → attach-and-request
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Component: Bugzilla-General → Attachments & Requests
Ever confirmed: true
Target Milestone: --- → Bugzilla 5.0
Ah, this duplicates some work that is being done in another patch (the one about only storing text attachments in the database).
Comment on attachment 557936 [details] [diff] [review] Move unlink code from cgi to pm r=LpSolit
Attachment #557936 - Flags: review?(LpSolit) → review+
As we have no API which can delete attachments yet, there is no need to take this patch for 4.2.
Assignee: attach-and-request → c1541
Status: NEW → ASSIGNED
And thanks to the reporter for the patch. :) I modified it slightly to match what mkanat did in bug 577532. Committing to: bzr+ssh://email@example.com/bugzilla/trunk/ modified attachment.cgi modified Bugzilla/Attachment.pm Committed revision 8037.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.