Webgl Water demo not working, with "compile error: ERROR: 0:1: 'unexpected EOF' : syntax error"

RESOLVED FIXED

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Unassigned)

Tracking

Trunk
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

6 years ago
STR: Load http://madebyevan.com/webgl-water/
EXPECTED RESULTS: Pretty rippling water.
ACTUAL RESULTS:   Black canvas, saying:
  compile error: ERROR: 0:1: 'unexpected EOF' : syntax error

Regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e58e98a89827&tochange=e87454393401

Bug 680722 is the only checkin in that range to mention WebGL -- assuming regression from that.

(This might be a duplicate of bug 683710, which is also a regression from that checkin, but I'm filing this separately for now since the "compile error" warning message is different from the one mentioned on that bug.)
Indeed probably a duplicate of 683710. The most probable thing is that as the patch from bug 680722 causes ShaderSource to reject the source string, we're subsequently compiling an empty shader source, which would explain the unexpected-EOF message.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 683710
Fixed by backout: http://hg.mozilla.org/mozilla-central/rev/e1d9d6120f84
Resolution: DUPLICATE → FIXED
You need to log in before you can comment on or make changes to this bug.