Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Remove private browsing code from nsEditorSpellCheck.cpp

RESOLVED FIXED in mozilla9

Status

()

Core
Editor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: arno renevier, Assigned: arno renevier)

Tracking

unspecified
mozilla9
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Since bug 679784 is fixed, it's possible to remove private browsing mode handling from nsEditorSpellCheck.cpp

I had deliberately not done that in bug 679784 to leave bug 679784 and bug 678842 independent. So, in case, one of them has to be backouted for whatever reason, this can be done without touching the other one.
(Assignee)

Updated

6 years ago
Depends on: 678842, 679784
Are you interested in taking this, Arno?
(Assignee)

Comment 2

6 years ago
Created attachment 558049 [details] [diff] [review]
patch proposal

patch proposal.
Here is try server result:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&tree=Try&rev=226e2af677ba
Assignee: nobody → arno
Attachment #558049 - Flags: review?(ehsan)
Comment on attachment 558049 [details] [diff] [review]
patch proposal

Review of attachment 558049 [details] [diff] [review]:
-----------------------------------------------------------------

r=me withe the comment below addressed.

::: editor/composer/src/nsEditorSpellCheck.cpp
@@ +747,5 @@
>  
>  void 
>  nsEditorSpellCheck::ShutDown() {
> +  if (gDictionaryStore) {
> +    nsMemory::Free(gDictionaryStore);

gDictionaryStore is allocated using operator new, so you should deallocate it using operator delete.
Attachment #558049 - Flags: review?(ehsan) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 558411 [details] [diff] [review]
updated patch: use delete to deallocate gDictionaryStore
Attachment #558049 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/0392944114b5
Keywords: checkin-needed
Target Milestone: --- → mozilla9
http://hg.mozilla.org/mozilla-central/rev/0392944114b5
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.