684315 - Remove private browsing code from nsEditorSpellCheck.cpp

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[arno renevier]

Since bug 679784 is fixed, it's possible to remove private browsing mode handling from nsEditorSpellCheck.cpp

I had deliberately not done that in bug 679784 to leave bug 679784 and bug 678842 independent. So, in case, one of them has to be backouted for whatever reason, this can be done without touching the other one.

Comment 1

[(no longer active)]

Are you interested in taking this, Arno?

Comment 2

[arno renevier]

Attachment: patch proposal

patch proposal.
Here is try server result:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&tree=Try&rev=226e2af677ba

Comment 3

[(no longer active)]

Comment on attachment 558049 [details] [diff] [review]
patch proposal

Review of attachment 558049 [details] [diff] [review]:
-----------------------------------------------------------------

r=me withe the comment below addressed.

::: editor/composer/src/nsEditorSpellCheck.cpp
@@ +747,5 @@
>  
>  void 
>  nsEditorSpellCheck::ShutDown() {
> +  if (gDictionaryStore) {
> +    nsMemory::Free(gDictionaryStore);

gDictionaryStore is allocated using operator new, so you should deallocate it using operator delete.

Comment 4

[arno renevier]

Attachment: updated patch: use delete to deallocate gDictionaryStore

Comment 5

[(no longer active)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/0392944114b5

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/0392944114b5