Closed
Bug 684337
Opened 13 years ago
Closed 13 years ago
JS shell won't compile
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: billm, Assigned: igor)
Details
Attachments
(1 file)
2.19 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
It looks like bug 681884 broke non-JS_THREADSAFE builds. /home/billm/mozilla/in0/js/src/jsgc.cpp:1158:65: error: no ‘void* js::gc::ArenaLists::allocateFromArena(JSContext*, js::gc::AllocKind)’ member function declared in class ‘js::gc::ArenaLists’ /home/billm/mozilla/in0/js/src/jsgc.cpp:1260:59: error: no ‘void js::gc::ArenaLists::finalizeNow(JSContext*, js::gc::AllocKind)’ member function declared in class ‘js::gc::ArenaLists’ /home/billm/mozilla/in0/js/src/jsgc.cpp:1269:61: error: no ‘void js::gc::ArenaLists::finalizeLater(JSContext*, js::gc::AllocKind)’ member function declared in class ‘js::gc::ArenaLists’ /home/billm/mozilla/in0/js/src/jsgc.cpp:1320:68: error: no ‘void js::gc::ArenaLists::backgroundFinalize(JSContext*, js::gc::ArenaHeader*)’ member function declared in class ‘js::gc::ArenaLists’ /home/billm/mozilla/in0/js/src/jsgc.cpp: In member function ‘void js::gc::ArenaLists::finalizeObjects(JSContext*)’: /home/billm/mozilla/in0/js/src/jsgc.cpp:1363:37: error: ‘finalizeNow’ was not declared in this scope /home/billm/mozilla/in0/js/src/jsgc.cpp:1384:40: error: ‘finalizeLater’ was not declared in this scope /home/billm/mozilla/in0/js/src/jsgc.cpp: In member function ‘void js::gc::ArenaLists::finalizeStrings(JSContext*)’: /home/billm/mozilla/in0/js/src/jsgc.cpp:1394:44: error: ‘finalizeLater’ was not declared in this scope /home/billm/mozilla/in0/js/src/jsgc.cpp:1397:45: error: ‘finalizeNow’ was not declared in this scope /home/billm/mozilla/in0/js/src/jsgc.cpp: In member function ‘void js::gc::ArenaLists::finalizeShapes(JSContext*)’: /home/billm/mozilla/in0/js/src/jsgc.cpp:1403:35: error: ‘finalizeNow’ was not declared in this scope /home/billm/mozilla/in0/js/src/jsgc.cpp: In member function ‘void js::gc::ArenaLists::finalizeScripts(JSContext*)’: /home/billm/mozilla/in0/js/src/jsgc.cpp:1410:36: error: ‘finalizeNow’ was not declared in this scope /home/billm/mozilla/in0/js/src/jsgc.cpp: In static member function ‘static void* js::gc::ArenaLists::refillFreeList(JSContext*, js::gc::AllocKind)’: /home/billm/mozilla/in0/js/src/jsgc.cpp:1471:47: error: ‘struct js::gc::ArenaLists’ has no member named ‘allocateFromArena’
Assignee | ||
Updated•13 years ago
|
Assignee: general → igor
Assignee | ||
Comment 1•13 years ago
|
||
The patch adds missing ifdef JS_THREADSAFE to jsgc.cpp and fixes ArenaLists member function declarations. For the latter I just dropped the JS_THREADSAFE as no harm is done by undefined member functions that are never called.
Attachment #557946 -
Flags: review?(wmccloskey)
Reporter | ||
Comment 2•13 years ago
|
||
Comment on attachment 557946 [details] [diff] [review] v1 Thanks.
Attachment #557946 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Jason already landed similar fix: http://hg.mozilla.org/integration/mozilla-inbound/rev/fff3dc9478ce
Comment 4•13 years ago
|
||
Yeah. Sorry for the duplicate work... I wasn't cc'd on this bug at the time and a quicksearch failed to find it. Someone complained about the errors on IRC, so I just pushed the fix. -> RESO FIXED
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•