Closed
Bug 684347
Opened 13 years ago
Closed 13 years ago
nsZipWriter::addEntryChannel(queue=true) creates corrupt zip file
Categories
(Core :: Networking: JAR, defect)
Core
Networking: JAR
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: kmag, Assigned: kmag)
Details
(Whiteboard: [inbound])
Attachments
(1 file, 4 obsolete files)
6.36 KB,
patch
|
Details | Diff | Splinter Review |
When channels are processed from a queue, the header for an entry is initialized but never written out to the zip file, which leaves the file corrupt. The attached patch removes the code duplication for stream and channel processing and fixes the issue.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #557938 -
Attachment is obsolete: true
Attachment #557939 -
Flags: review?(dtownsend)
Comment 2•13 years ago
|
||
Comment on attachment 557939 [details] [diff] [review] Proposed fix I'd like to see some unit tests for this before reviewing it
Attachment #557939 -
Flags: review?(dtownsend)
Assignee | ||
Comment 3•13 years ago
|
||
Do you want a separate test for this bug, or should I add them to test_asyncadd.js where they already fit comfortably?
Assignee | ||
Comment 4•13 years ago
|
||
Updated patch with tests.
Assignee: nobody → maglione.k
Attachment #557939 -
Attachment is obsolete: true
Attachment #558713 -
Flags: review?(dtownsend)
Updated•13 years ago
|
Attachment #558713 -
Flags: review?(dtownsend) → review+
Assignee | ||
Updated•13 years ago
|
Whiteboard: [needs landing]
Assignee | ||
Comment 5•13 years ago
|
||
Updated after PRBool code churn. Can someone land this please?
Attachment #558713 -
Attachment is obsolete: true
Updated•13 years ago
|
Keywords: checkin-needed
Comment 6•13 years ago
|
||
Actually Kris, if you could attach a patch that follows the conventions in http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed, it will be a lot easier to check in the patch.
Keywords: checkin-needed
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 8•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/926699a40a9b
Keywords: checkin-needed
Whiteboard: [needs landing] → [inbound]
Comment 9•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/926699a40a9b
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•