Created attachment 557938 [details] Proposed fix When channels are processed from a queue, the header for an entry is initialized but never written out to the zip file, which leaves the file corrupt. The attached patch removes the code duplication for stream and channel processing and fixes the issue.
Created attachment 557939 [details] [diff] [review] Proposed fix
Comment on attachment 557939 [details] [diff] [review] Proposed fix I'd like to see some unit tests for this before reviewing it
Do you want a separate test for this bug, or should I add them to test_asyncadd.js where they already fit comfortably?
Created attachment 558713 [details] [diff] [review] Updated patch Updated patch with tests.
Created attachment 569533 [details] [diff] [review] Updated patch Updated after PRBool code churn. Can someone land this please?
Actually Kris, if you could attach a patch that follows the conventions in http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed, it will be a lot easier to check in the patch.
Created attachment 569543 [details] [diff] [review] Updated commit message and authorship info. jdm: Thanks.