Closed
      
        Bug 684406
      
      
        Opened 14 years ago
          Closed 14 years ago
      
        
    
  
mobile release tagging should bump browser/version.txt 
    Categories
(Release Engineering :: General, defect)
        Release Engineering
          
        
        
      
        
    
        General
          
        
        
      
        
    Tracking
(Not tracked)
        RESOLVED
        FIXED
        
    
  
People
(Reporter: mozilla, Assigned: mozilla)
References
Details
(Whiteboard: [automation][releases])
Attachments
(2 files)
| 48.65 KB,
          image/png         | Details | |
| 4.37 KB,
          patch         | rail
:
              
              review+ mozilla
:
              
              checked-in+ | Details | Diff | Splinter Review | 
For some reason we're adding the browser version to the user agent string for mobile release builds.  We currently don't bump it, so whenever Fennec tags before Firefox on a build 1, the user agent string is wrong.
|   | ||
| Comment 1•14 years ago
           | ||
screenshot of BuildID in Fennec 6.0.2 about page
| Assignee | ||
| Comment 2•14 years ago
           | ||
Assignee: nobody → aki
        Attachment #557991 -
        Flags: review?(rail)
|   | ||
| Updated•14 years ago
           | 
        Attachment #557991 -
        Flags: review?(rail) → review+
| Assignee | ||
| Comment 3•14 years ago
           | ||
Comment on attachment 557991 [details] [diff] [review]
bump browser/version.txt in mobile tagging
http://hg.mozilla.org/build/buildbot-configs/rev/376020f867cc
        Attachment #557991 -
        Flags: checked-in+
| Assignee | ||
| Updated•14 years ago
           | 
Flags: needs-reconfig?
| Assignee | ||
| Updated•14 years ago
           | 
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: needs-reconfig?
Resolution: --- → FIXED
|   | ||
| Comment 4•14 years ago
           | ||
landed with 2011-09-06 reconfig
| Comment 5•14 years ago
           | ||
Is there a bug on file for fixing Fennec to get the user agent from the right place?
| Comment 6•14 years ago
           | ||
(In reply to Ben Hearsum [:bhearsum] from comment #5)
> Is there a bug on file for fixing Fennec to get the user agent from the
> right place?
It does get it from the right place, the version.txt that completes Firefox/* there is the global Gecko "Firefox UA compat" that explicitly uses the browser/ version string.
If we only, ever, intend to make Firefox version === Gecko Version, we can drop browser/config/version.txt entirely for the milestone, and use the milestone here. But if we don't this is correct behavior, if sadly a PITA when we have multiple relbranches on releng side.
| Comment 7•14 years ago
           | ||
(In reply to Justin Wood (:Callek) from comment #6)
> (In reply to Ben Hearsum [:bhearsum] from comment #5)
> > Is there a bug on file for fixing Fennec to get the user agent from the
> > right place?
> 
> It does get it from the right place, the version.txt that completes
> Firefox/* there is the global Gecko "Firefox UA compat" that explicitly uses
> the browser/ version string.
Ah, and I see that we don't have an equivalent file for mobile :(.
| Updated•12 years ago
           | 
Product: mozilla.org → Release Engineering
          You need to log in
          before you can comment on or make changes to this bug.
        
 buildID screenshot
 buildID screenshot
            
Description
•