Last Comment Bug 684444 - Clicking on a background tab's close button selects the tab before closing it
: Clicking on a background tab's close button selects the tab before closing it
Status: RESOLVED FIXED
: regression
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: 9 Branch
: x86 Windows Vista
: -- normal (vote)
: Firefox 9
Assigned To: Dão Gottwald [:dao]
:
Mentors:
: 684765 685300 (view as bug list)
Depends on:
Blocks: 679255
  Show dependency treegraph
 
Reported: 2011-09-02 20:58 PDT by Eric
Modified: 2011-09-13 02:57 PDT (History)
8 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.03 KB, patch)
2011-09-05 07:41 PDT, Dão Gottwald [:dao]
enndeakin: review+
Details | Diff | Splinter Review

Description Eric 2011-09-02 20:58:48 PDT
User Agent: Mozilla/5.0 (Windows NT 6.0; rv:9.0a1) Gecko/20110902 Firefox/9.0a1
Build ID: 20110902072738

Steps to reproduce:

Whenever I close a tab in Nightly, before the tab actually closes it will show the tab I am trying to close for a quick second before it will actually close it. This is only if you're on a different tab to the one you're trying to close.


Actual results:

I have explained in the above paragraph.


Expected results:

It shouldn't have shown the tab I was closing at all.
Comment 1 Tim (fmdeveloper) 2011-09-02 21:45:33 PDT
Does the issue still occur if you start Firefox in Safe Mode? http://support.mozilla.com/en-US/kb/Safe+Mode

How about with a new, empty profile? http://support.mozilla.com/en-US/kb/Basic%20Troubleshooting#w_8-make-a-new-profile

Please post the graphics section from about:support
Comment 2 7842.9 2011-09-02 23:41:39 PDT
Mozilla/5.0 (Windows NT 5.1; rv:9.0a1) Gecko/20110902 Firefox/9.0a1

I'm getting this too, it's probably because of the fix for bug 679255.
Comment 3 Eric 2011-09-03 00:58:26 PDT
(In reply to Tim (fmdeveloper) from comment #1)
> Does the issue still occur if you start Firefox in Safe Mode?
> http://support.mozilla.com/en-US/kb/Safe+Mode
> 
> How about with a new, empty profile?
> http://support.mozilla.com/en-US/kb/Basic%20Troubleshooting#w_8-make-a-new-
> profile
> 
> Please post the graphics section from about:support

I have just got done trying it in both safe mode & a new profile and the bug still persists. And according to the comment above this one I'm not the only person with this problem. Thanks for the reply.
Comment 4 Eric 2011-09-03 01:03:18 PDT
> Please post the graphics section from about:support


http://i.imgur.com/vJP4t.png
Comment 5 Tim (fmdeveloper) 2011-09-03 17:25:32 PDT
I think I see what you mean - it does briefly appear to change to the tab before closing

Confirming and cc'ing for additional eyes
Comment 6 Dão Gottwald [:dao] 2011-09-05 07:41:52 PDT
Created attachment 558284 [details] [diff] [review]
patch

I tried to write a test for this, but it's a pain since tabbrowser.xml uses setTimeout in addTab() to show the close button and tabbox.xml uses setTimeout in the mousedown handler.
Comment 7 ithinc 2011-09-05 17:16:45 PDT
*** Bug 684765 has been marked as a duplicate of this bug. ***
Comment 8 ithinc 2011-09-05 17:31:45 PDT
Note that there's another drawback from 679255's landing. Right-click on the active tab focuses the tab itself occasionally, showing the dotted lines.
Comment 10 Dão Gottwald [:dao] 2011-09-07 14:32:00 PDT
*** Bug 685300 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.