Last Comment Bug 684465 - Add Reflect.parse support to xpcshell
: Add Reflect.parse support to xpcshell
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Alex Vincent [:WeirdAl]
:
: Andrew Overholt [:overholt]
Mentors:
Depends on: 533874
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-03 01:34 PDT by Alex Vincent [:WeirdAl]
Modified: 2011-09-11 06:33 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch, v1 (4.02 KB, patch)
2011-09-09 15:11 PDT, Alex Vincent [:WeirdAl]
jorendorff: review+
bzbarsky: review+
Details | Diff | Splinter Review

Description Alex Vincent [:WeirdAl] 2011-09-03 01:34:33 PDT
In FF Aurora, Firefox chrome code can access the Reflect API's.  The xpcshell application cannot.
Comment 1 Alex Vincent [:WeirdAl] 2011-09-08 19:01:52 PDT
I think I found the right place to insert the needed code:
http://hg.mozilla.org/mozilla-central/annotate/b57d50c6c046/js/src/xpconnect/shell/xpcshell.cpp#l1971

We seem to be creating a few helpful top-level objects here.

Corresponding code in the JS shell:
http://hg.mozilla.org/mozilla-central/annotate/b57d50c6c046/js/src/shell/js.cpp#l5304
Comment 2 Alex Vincent [:WeirdAl] 2011-09-09 15:11:13 PDT
Created attachment 559590 [details] [diff] [review]
patch, v1
Comment 3 Alex Vincent [:WeirdAl] 2011-09-09 15:16:27 PDT
I don't have commit privileges, and I'm not sure if this should go on mozilla-inbound, mozilla-central, or tracemonkey first.
Comment 4 Boris Zbarsky [:bz] (still a bit busy) 2011-09-09 18:59:27 PDT
Comment on attachment 559590 [details] [diff] [review]
patch, v1

r=me
Comment 5 Phil Ringnalda (:philor) 2011-09-10 21:52:49 PDT
There is no TraceMonkey, only Inbound.

http://hg.mozilla.org/integration/mozilla-inbound/rev/b384cfab8b1d
Comment 6 Matt Brubeck (:mbrubeck) 2011-09-11 06:33:36 PDT
http://hg.mozilla.org/mozilla-central/rev/b384cfab8b1d

Note You need to log in before you can comment on or make changes to this bug.