Closed Bug 684465 Opened 8 years ago Closed 8 years ago

Add Reflect.parse support to xpcshell

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: WeirdAl, Assigned: WeirdAl)

References

Details

Attachments

(1 file)

In FF Aurora, Firefox chrome code can access the Reflect API's.  The xpcshell application cannot.
I think I found the right place to insert the needed code:
http://hg.mozilla.org/mozilla-central/annotate/b57d50c6c046/js/src/xpconnect/shell/xpcshell.cpp#l1971

We seem to be creating a few helpful top-level objects here.

Corresponding code in the JS shell:
http://hg.mozilla.org/mozilla-central/annotate/b57d50c6c046/js/src/shell/js.cpp#l5304
Attached patch patch, v1Splinter Review
Assignee: nobody → ajvincent
Status: NEW → ASSIGNED
Attachment #559590 - Flags: review?(jorendorff)
Attachment #559590 - Flags: review?(jorendorff) → review+
I don't have commit privileges, and I'm not sure if this should go on mozilla-inbound, mozilla-central, or tracemonkey first.
Keywords: checkin-needed
Attachment #559590 - Flags: review?(bzbarsky)
Keywords: checkin-needed
Comment on attachment 559590 [details] [diff] [review]
patch, v1

r=me
Attachment #559590 - Flags: review?(bzbarsky) → review+
Keywords: checkin-needed
There is no TraceMonkey, only Inbound.

http://hg.mozilla.org/integration/mozilla-inbound/rev/b384cfab8b1d
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/b384cfab8b1d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.