Closed
Bug 684465
Opened 13 years ago
Closed 13 years ago
Add Reflect.parse support to xpcshell
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: WeirdAl, Assigned: WeirdAl)
References
Details
Attachments
(1 file)
|
4.02 KB,
patch
|
jorendorff
:
review+
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
In FF Aurora, Firefox chrome code can access the Reflect API's. The xpcshell application cannot.
|
Assignee | |
Comment 1•13 years ago
|
||
I think I found the right place to insert the needed code: http://hg.mozilla.org/mozilla-central/annotate/b57d50c6c046/js/src/xpconnect/shell/xpcshell.cpp#l1971 We seem to be creating a few helpful top-level objects here. Corresponding code in the JS shell: http://hg.mozilla.org/mozilla-central/annotate/b57d50c6c046/js/src/shell/js.cpp#l5304
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Updated•13 years ago
|
Attachment #559590 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
I don't have commit privileges, and I'm not sure if this should go on mozilla-inbound, mozilla-central, or tracemonkey first.
Keywords: checkin-needed
|
|
Assignee | |
Updated•13 years ago
|
Attachment #559590 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
Comment on attachment 559590 [details] [diff] [review] patch, v1 r=me
Attachment #559590 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 5•13 years ago
|
||
There is no TraceMonkey, only Inbound. http://hg.mozilla.org/integration/mozilla-inbound/rev/b384cfab8b1d
Keywords: checkin-needed
Whiteboard: [inbound]
|
||
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b384cfab8b1d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•