Last Comment Bug 684471 - Make nsGenericHTMLFormElement::mFieldSet a nsHTMLFieldSetElement*
: Make nsGenericHTMLFormElement::mFieldSet a nsHTMLFieldSetElement*
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla9
Assigned To: :Ms2ger (⌚ UTC+1/+2)
: Andrew Overholt [:overholt]
Depends on:
  Show dependency treegraph
Reported: 2011-09-03 02:34 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-09-18 07:00 PDT (History)
2 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (7.38 KB, patch)
2011-09-03 02:34 PDT, :Ms2ger (⌚ UTC+1/+2)
peterv: review+
mounir: feedback+
Details | Diff | Splinter Review

Description User image :Ms2ger (⌚ UTC+1/+2) 2011-09-03 02:34:57 PDT
Created attachment 558052 [details] [diff] [review]
Patch v1
Comment 1 User image Mounir Lamouri (:mounir) 2011-09-05 03:29:24 PDT
Comment on attachment 558052 [details] [diff] [review]
Patch v1

Review of attachment 558052 [details] [diff] [review]:

Ms2ger, I suppose you wrote this patch to prevent the static_cast's at various places? 

f=mounir, could be a r+ if Peter wants to delegate the review.
Comment 2 User image :Ms2ger (⌚ UTC+1/+2) 2011-09-05 04:43:57 PDT
Yeah, and to make it clear that it's always a HTMLFieldSetElement.
Comment 3 User image :Ms2ger (⌚ UTC+1/+2) 2011-09-18 07:00:41 PDT

Note You need to log in before you can comment on or make changes to this bug.