The default bug view has changed. See this FAQ.

Bounding boxes for strokes are unnecessarily big for many shapes

RESOLVED FIXED in mozilla9

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Robert Longson, Assigned: Robert Longson)

Tracking

Trunk
mozilla9
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
text, rect, circle, ellipse don't have vertices but the bounding boxes we calculate assume that they might have.
(Assignee)

Comment 1

6 years ago
Created attachment 558057 [details] [diff] [review]
patch
Assignee: nobody → longsonr
Attachment #558057 - Flags: review?(roc)
(Assignee)

Updated

6 years ago
Blocks: 647687
Comment on attachment 558057 [details] [diff] [review]
patch

Review of attachment 558057 [details] [diff] [review]:
-----------------------------------------------------------------

Test?
Attachment #558057 - Flags: review?(roc) → review+
(Assignee)

Comment 3

6 years ago
getBBox ignores strokes. I could do a getBoundingClientRect mochitest on a rect with a stroke at the moment but there seems some question over whether that method should or should not include the stroke. Currently Firefox and IE do include the stroke but the w3c specification says not to which I've raised as an issue. Would you like a getBoundingClientRect based test?
(Assignee)

Comment 4

6 years ago
Do you want a getBoundingClientRect based test even if that may be returning the wrong thing currently?
Yes I think so
(Assignee)

Comment 6

6 years ago
sent to try with tests https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=fc31fb935a31
(Assignee)

Updated

6 years ago
Flags: in-testsuite+
(Assignee)

Comment 7

6 years ago
pushed http://hg.mozilla.org/integration/mozilla-inbound/rev/620b73b3d768
Depends on: 684790
http://hg.mozilla.org/mozilla-central/rev/620b73b3d768
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.