Closed Bug 684479 Opened 8 years ago Closed 8 years ago

Bounding boxes for strokes are unnecessarily big for many shapes

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: longsonr, Assigned: longsonr)

References

Details

Attachments

(1 file)

text, rect, circle, ellipse don't have vertices but the bounding boxes we calculate assume that they might have.
Attached patch patchSplinter Review
Assignee: nobody → longsonr
Attachment #558057 - Flags: review?(roc)
Blocks: 647687
Comment on attachment 558057 [details] [diff] [review]
patch

Review of attachment 558057 [details] [diff] [review]:
-----------------------------------------------------------------

Test?
Attachment #558057 - Flags: review?(roc) → review+
getBBox ignores strokes. I could do a getBoundingClientRect mochitest on a rect with a stroke at the moment but there seems some question over whether that method should or should not include the stroke. Currently Firefox and IE do include the stroke but the w3c specification says not to which I've raised as an issue. Would you like a getBoundingClientRect based test?
Do you want a getBoundingClientRect based test even if that may be returning the wrong thing currently?
Flags: in-testsuite+
Depends on: 684790
http://hg.mozilla.org/mozilla-central/rev/620b73b3d768
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.