684479 - Bounding boxes for strokes are unnecessarily big for many shapes

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

text, rect, circle, ellipse don't have vertices but the bounding boxes we calculate assume that they might have.

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 558057 [details] [diff] [review]
patch

Review of attachment 558057 [details] [diff] [review]:
-----------------------------------------------------------------

Test?

Comment 3

[Robert Longson [:longsonr]]

getBBox ignores strokes. I could do a getBoundingClientRect mochitest on a rect with a stroke at the moment but there seems some question over whether that method should or should not include the stroke. Currently Firefox and IE do include the stroke but the w3c specification says not to which I've raised as an issue. Would you like a getBoundingClientRect based test?

Comment 4

[Robert Longson [:longsonr]]

Do you want a getBoundingClientRect based test even if that may be returning the wrong thing currently?

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yes I think so

Comment 6

[Robert Longson [:longsonr]]

sent to try with tests https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=fc31fb935a31

Comment 7

[Robert Longson [:longsonr]]

pushed http://hg.mozilla.org/integration/mozilla-inbound/rev/620b73b3d768

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/620b73b3d768