Closed
Bug 684582
Opened 13 years ago
Closed 13 years ago
Fix strict warnings: assignment to undeclared variable
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.0
People
(Reporter: ssitter, Assigned: ssitter)
Details
Attachments
(2 files)
12.35 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
11.11 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
Fix some warnings I saw during testing: Warning: assignment to undeclared variable col Source file: chrome://calendar/content/calendar-multiday-view.xml Line: 3207 Warning: assignment to undeclared variable itemBox Source file: chrome://calendar/content/calendar-multiday-view.xml Line: 2068 Warning: assignment to undeclared variable box Source file: chrome://calendar/content/calendar-month-view.xml Line: 878 Warning: assignment to undeclared variable oldbox Source file: chrome://calendar/content/calendar-month-view.xml Line: 586 Warning: assignment to undeclared variable newbox Source file: chrome://calendar/content/calendar-month-view.xml Line: 597 Warning: assignment to undeclared variable shadow Source file: chrome://calendar/content/widgets/calendar-widgets.xml Line: 411 Warning: assignment to undeclared variable item Source file: chrome://calendar/content/calendar-task-tree.xml Line: 577 Warning: assignment to undeclared variable selectedTasks Source file: chrome://calendar/content/calendar-print-dialog.js Line: 173 Warning: assignment to undeclared variable i Source file: file:///.../components/calStorageCalendar.js Line: 2052 Warning: assignment to undeclared variable exid Source file: file:///.../components/calStorageCalendar.js Line: 2122 Warning: assignment to undeclared variable att Source file: file:///.../components/calStorageCalendar.js Line: 2139 Warning: assignment to undeclared variable ritem Source file: file:///.../calendar-js/calRecurrenceInfo.js Line: 533 Warning: assignment to undeclared variable ritem Source file: file:///.../calendar-js/calRecurrenceInfo.js Line: 574 Warning: assignment to undeclared variable maybeNewStart Source file:///.../calendar-js/calMonthGridPrinter.js Line: 123 Warning: assignment to undeclared variable itemListIndex Source file:///.../calendar-js/calMonthGridPrinter.js Line: 322
Attachment #558141 -
Flags: review?(philipp)
Comment 1•13 years ago
|
||
Comment on attachment 558141 [details] [diff] [review] patch Review of attachment 558141 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, r=philipp. Feel free to push to all three trees, a=philipp
Attachment #558141 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Checked in to https://hg.mozilla.org/comm-central/rev/ffee873dfdbd Ported back to https://hg.mozilla.org/releases/comm-aurora/rev/f2a20e7a2010 Ported back to https://hg.mozilla.org/releases/comm-beta/rev/fe74f461b4b8
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0b6
Assignee | ||
Comment 3•13 years ago
|
||
fix more warnings and minor style nits
Attachment #560708 -
Flags: review?(philipp)
Assignee | ||
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•13 years ago
|
Status: REOPENED → ASSIGNED
Comment 4•13 years ago
|
||
Comment on attachment 560708 [details] [diff] [review] patch 2 r=philipp
Attachment #560708 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Comment on attachment 560708 [details] [diff] [review] patch 2 Pushed to https://hg.mozilla.org/comm-central/rev/f02d813c0ccf
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 6•13 years ago
|
||
Another patch pushed that fixes warnings: comm-central rev 78ea7266922d comm-aurora rev 35295351770b comm-beta rev 27cbe191e3fa
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 7•13 years ago
|
||
Additional fixes: comm-central changeset 26ac80defe36 releases/comm-aurora changeset b9523218a326 releases/comm-beta changeset 177be7c55fd4
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Target Milestone: 1.0b7 → 1.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•