684582 - Fix strict warnings: assignment to undeclared variable

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: patch

Fix some warnings I saw during testing:

Warning: assignment to undeclared variable col
Source file: chrome://calendar/content/calendar-multiday-view.xml Line: 3207

Warning: assignment to undeclared variable itemBox
Source file: chrome://calendar/content/calendar-multiday-view.xml Line: 2068

Warning: assignment to undeclared variable box
Source file: chrome://calendar/content/calendar-month-view.xml Line: 878

Warning: assignment to undeclared variable oldbox
Source file: chrome://calendar/content/calendar-month-view.xml Line: 586

Warning: assignment to undeclared variable newbox
Source file: chrome://calendar/content/calendar-month-view.xml Line: 597

Warning: assignment to undeclared variable shadow
Source file: chrome://calendar/content/widgets/calendar-widgets.xml Line: 411

Warning: assignment to undeclared variable item
Source file: chrome://calendar/content/calendar-task-tree.xml Line: 577

Warning: assignment to undeclared variable selectedTasks
Source file: chrome://calendar/content/calendar-print-dialog.js Line: 173

Warning: assignment to undeclared variable i
Source file: file:///.../components/calStorageCalendar.js Line: 2052

Warning: assignment to undeclared variable exid
Source file: file:///.../components/calStorageCalendar.js Line: 2122

Warning: assignment to undeclared variable att
Source file: file:///.../components/calStorageCalendar.js Line: 2139

Warning: assignment to undeclared variable ritem
Source file: file:///.../calendar-js/calRecurrenceInfo.js Line: 533

Warning: assignment to undeclared variable ritem
Source file: file:///.../calendar-js/calRecurrenceInfo.js Line: 574

Warning: assignment to undeclared variable maybeNewStart
Source file:///.../calendar-js/calMonthGridPrinter.js Line: 123

Warning: assignment to undeclared variable itemListIndex
Source file:///.../calendar-js/calMonthGridPrinter.js Line: 322

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 558141 [details] [diff] [review]
patch

Review of attachment 558141 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=philipp. Feel free to push to all three trees, a=philipp

Comment 2

[Stefan Sitter [:ssitter]]

Checked in to https://hg.mozilla.org/comm-central/rev/ffee873dfdbd

Ported back to https://hg.mozilla.org/releases/comm-aurora/rev/f2a20e7a2010

Ported back to https://hg.mozilla.org/releases/comm-beta/rev/fe74f461b4b8

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: patch 2

fix more warnings and minor style nits

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 560708 [details] [diff] [review]
patch 2

r=philipp

Comment 5

[Stefan Sitter [:ssitter]]

Comment on attachment 560708 [details] [diff] [review]
patch 2

Pushed to https://hg.mozilla.org/comm-central/rev/f02d813c0ccf

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Another patch pushed that fixes warnings:

comm-central rev 78ea7266922d
comm-aurora rev 35295351770b
comm-beta rev 27cbe191e3fa

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Additional fixes:

comm-central changeset 26ac80defe36
releases/comm-aurora changeset b9523218a326
releases/comm-beta changeset 177be7c55fd4