Last Comment Bug 684662 - js\src\methodjit/MethodJIT.h(690) : warning C4305: 'argument' : truncation from 'js::MaybeConstruct' to 'bool'
: js\src\methodjit/MethodJIT.h(690) : warning C4305: 'argument' : truncation fr...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86 Windows Vista
: -- normal (vote)
: mozilla9
Assigned To: Makoto Kato [:m_kato]
:
Mentors:
Depends on:
Blocks: 680951
  Show dependency treegraph
 
Reported: 2011-09-04 22:52 PDT by Makoto Kato [:m_kato]
Modified: 2011-09-05 11:45 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (786 bytes, patch)
2011-09-04 23:04 PDT, Makoto Kato [:m_kato]
bhackett1024: review+
Details | Diff | Splinter Review

Description Makoto Kato [:m_kato] 2011-09-04 22:52:00 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=6274862&full=1

d:/mozilla-build/python25/python2.5.exe -O e:/builds/moz2_slave/m-cen-w32/build/js/src/build/cl.py cl -Fojsanalyze.obj -c   -DOSTYPE=\"WINNT5.2\" -DOSARCH=WINNT -DEXPORT_JS_API -DIMPL_MFBT -DJS_HAS_CTYPES -DDLL_PREFIX=\"\" -DDLL_SUFFIX=\".dll\" -Ictypes/libffi/include -I.  -I/e/builds/moz2_slave/m-cen-w32/build/js/src -I. -I./../../dist/include -I./../../dist/include/nsprpub  -Ie:/builds/moz2_slave/m-cen-w32/build/obj-firefox/dist/include/nspr  -I/e/builds/moz2_slave/m-cen-w32/build/js/src -I/e/builds/moz2_slave/m-cen-w32/build/js/src/assembler -I/e/builds/moz2_slave/m-cen-w32/build/js/src/yarr    -GR- -TP -nologo -wd4345 -D_CRT_SECURE_NO_WARNINGS -W3 -Gy -Fdgenerated.pdb -wd4244 -wd4800 -we4553  -DNDEBUG -DTRIMMED -Zi -Zi -UDEBUG -DNDEBUG -O2 -Oy -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DENABLE_JIT=1 -MD            -FI ./js-confdefs.h -DMOZILLA_CLIENT /e/builds/moz2_slave/m-cen-w32/build/js/src/jsanalyze.cpp
jsanalyze.cpp

e:\builds\moz2_slave\m-cen-w32\build\js\src\methodjit/MethodJIT.h(690) : warning C4305: 'argument' : truncation from 'js::MaybeConstruct' to 'bool'
Comment 1 Makoto Kato [:m_kato] 2011-09-04 22:55:00 PDT
This is by bug 680951.
Comment 2 Makoto Kato [:m_kato] 2011-09-04 23:04:01 PDT
Created attachment 558229 [details] [diff] [review]
fix
Comment 3 Brian Hackett (:bhackett) 2011-09-05 01:09:18 PDT
Comment on attachment 558229 [details] [diff] [review]
fix

Review of attachment 558229 [details] [diff] [review]:
-----------------------------------------------------------------

Can you change the arguments passed to true/false instead?
Comment 4 Makoto Kato [:m_kato] 2011-09-05 04:22:57 PDT
land with changing to true/false
http://hg.mozilla.org/integration/mozilla-inbound/rev/e00b68fc6df9

Note You need to log in before you can comment on or make changes to this bug.