Last Comment Bug 684720 - NetworkGeolocationProvider.js uses a sync xhr
: NetworkGeolocationProvider.js uses a sync xhr
Status: RESOLVED FIXED
[mentor=jdm][lang=js]
:
Product: Core
Classification: Components
Component: Geolocation (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla13
Assigned To: Corey Richardson (:cmr)
:
Mentors:
Depends on:
Blocks: 721336
  Show dependency treegraph
 
Reported: 2011-09-05 08:25 PDT by Josh Matthews [:jdm]
Modified: 2012-02-06 00:55 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (538 bytes, patch)
2012-01-21 14:28 PST, Corey Richardson (:cmr)
josh: review+
Details | Diff | Review

Description Josh Matthews [:jdm] 2011-09-05 08:25:32 PDT
Async would be preferred.
Comment 1 Josh Matthews [:jdm] 2011-10-06 22:59:39 PDT
I would love for someone to try fixing this. https://developer.mozilla.org/En/XMLHttpRequest/Using_XMLHttpRequest has an example of how sync vs async XHR code differs. Once that change is made, it's just a matter of making sure the tests still pass.
Comment 2 Corey Richardson (:cmr) 2012-01-21 14:28:55 PST
Created attachment 590513 [details] [diff] [review]
Patch

Not sure what tests to run.
Comment 3 Josh Matthews [:jdm] 2012-01-21 14:34:14 PST
Thanks! You should run the geolocation mochitests (https://developer.mozilla.org/en/Mochitest): TEST_PATH=dom/tests/mochitest/geolocation/ make -C objdir mochitest-plain
Comment 4 Corey Richardson (:cmr) 2012-02-05 14:01:59 PST
As far as I can tell, the tests pass. (Sorry for huge delay, midterms + illness struck me)
Comment 5 Josh Matthews [:jdm] 2012-02-05 14:50:38 PST
Comment on attachment 590513 [details] [diff] [review]
Patch

Great! Let's send it through try to make sure.
Comment 6 Mozilla RelEng Bot 2012-02-05 14:54:25 PST
Autoland Patchset:
	Patches: 590513
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/6ad4c8d89359
Try run started, revision 6ad4c8d89359. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=6ad4c8d89359
Comment 7 Mozilla RelEng Bot 2012-02-05 19:15:19 PST
Try run for 6ad4c8d89359 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=6ad4c8d89359
Results (out of 209 total builds):
    success: 187
    warnings: 22
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-6ad4c8d89359
Comment 8 Josh Matthews [:jdm] 2012-02-05 20:29:11 PST
http://hg.mozilla.org/integration/mozilla-inbound/rev/28e55051da13

Thanks!
Comment 9 Marco Bonardo [::mak] 2012-02-06 00:55:16 PST
https://hg.mozilla.org/mozilla-central/rev/28e55051da13

Note You need to log in before you can comment on or make changes to this bug.