NetworkGeolocationProvider.js uses a sync xhr

RESOLVED FIXED in mozilla13

Status

()

Core
Geolocation
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jdm, Assigned: cmr)

Tracking

(Blocks: 1 bug)

unspecified
mozilla13
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=jdm][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Async would be preferred.
(Reporter)

Comment 1

6 years ago
I would love for someone to try fixing this. https://developer.mozilla.org/En/XMLHttpRequest/Using_XMLHttpRequest has an example of how sync vs async XHR code differs. Once that change is made, it's just a matter of making sure the tests still pass.
Whiteboard: [mentor=jdm]
(Reporter)

Updated

6 years ago
Whiteboard: [mentor=jdm] → [mentor=jdm][lang=js]
(Assignee)

Comment 2

5 years ago
Created attachment 590513 [details] [diff] [review]
Patch

Not sure what tests to run.
(Reporter)

Comment 3

5 years ago
Thanks! You should run the geolocation mochitests (https://developer.mozilla.org/en/Mochitest): TEST_PATH=dom/tests/mochitest/geolocation/ make -C objdir mochitest-plain
(Reporter)

Updated

5 years ago
Blocks: 721336
(Assignee)

Comment 4

5 years ago
As far as I can tell, the tests pass. (Sorry for huge delay, midterms + illness struck me)
(Reporter)

Comment 5

5 years ago
Comment on attachment 590513 [details] [diff] [review]
Patch

Great! Let's send it through try to make sure.
Attachment #590513 - Flags: review+
(Reporter)

Updated

5 years ago
Whiteboard: [mentor=jdm][lang=js] → [mentor=jdm][lang=js][autoland]

Updated

5 years ago
Whiteboard: [mentor=jdm][lang=js][autoland] → [mentor=jdm][lang=js][autoland-in-queue]

Comment 6

5 years ago
Autoland Patchset:
	Patches: 590513
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/6ad4c8d89359
Try run started, revision 6ad4c8d89359. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=6ad4c8d89359

Comment 7

5 years ago
Try run for 6ad4c8d89359 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=6ad4c8d89359
Results (out of 209 total builds):
    success: 187
    warnings: 22
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-6ad4c8d89359

Updated

5 years ago
Whiteboard: [mentor=jdm][lang=js][autoland-in-queue] → [mentor=jdm][lang=js]
(Reporter)

Comment 8

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/28e55051da13

Thanks!
Assignee: nobody → corey
https://hg.mozilla.org/mozilla-central/rev/28e55051da13
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.