684720 - NetworkGeolocationProvider.js uses a sync xhr

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Josh Matthews [:jdm]]

Async would be preferred.

Comment 1

[Josh Matthews [:jdm]]

I would love for someone to try fixing this. https://developer.mozilla.org/En/XMLHttpRequest/Using_XMLHttpRequest has an example of how sync vs async XHR code differs. Once that change is made, it's just a matter of making sure the tests still pass.

Comment 2

[Corey Richardson (:cmr)]

Attachment: Patch

Not sure what tests to run.

Comment 3

[Josh Matthews [:jdm]]

Thanks! You should run the geolocation mochitests (https://developer.mozilla.org/en/Mochitest): TEST_PATH=dom/tests/mochitest/geolocation/ make -C objdir mochitest-plain

Comment 4

[Corey Richardson (:cmr)]

As far as I can tell, the tests pass. (Sorry for huge delay, midterms + illness struck me)

Comment 5

[Josh Matthews [:jdm]]

Comment on attachment 590513 [details] [diff] [review]
Patch

Great! Let's send it through try to make sure.

Comment 6

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 590513
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/6ad4c8d89359
Try run started, revision 6ad4c8d89359. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=6ad4c8d89359

Comment 7

[Mozilla RelEng Bot]

Try run for 6ad4c8d89359 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=6ad4c8d89359
Results (out of 209 total builds):
    success: 187
    warnings: 22
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-6ad4c8d89359

Comment 8

[Josh Matthews [:jdm]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/28e55051da13

Thanks!

Comment 9

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/28e55051da13