Closed Bug 684720 Opened 13 years ago Closed 12 years ago

NetworkGeolocationProvider.js uses a sync xhr

Categories

(Core :: DOM: Geolocation, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: jdm, Assigned: cmr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [mentor=jdm][lang=js])

Attachments

(1 file)

Async would be preferred.
I would love for someone to try fixing this. https://developer.mozilla.org/En/XMLHttpRequest/Using_XMLHttpRequest has an example of how sync vs async XHR code differs. Once that change is made, it's just a matter of making sure the tests still pass.
Whiteboard: [mentor=jdm]
Whiteboard: [mentor=jdm] → [mentor=jdm][lang=js]
Attached patch PatchSplinter Review
Not sure what tests to run.
Thanks! You should run the geolocation mochitests (https://developer.mozilla.org/en/Mochitest): TEST_PATH=dom/tests/mochitest/geolocation/ make -C objdir mochitest-plain
Blocks: 721336
As far as I can tell, the tests pass. (Sorry for huge delay, midterms + illness struck me)
Comment on attachment 590513 [details] [diff] [review]
Patch

Great! Let's send it through try to make sure.
Attachment #590513 - Flags: review+
Whiteboard: [mentor=jdm][lang=js] → [mentor=jdm][lang=js][autoland]
Whiteboard: [mentor=jdm][lang=js][autoland] → [mentor=jdm][lang=js][autoland-in-queue]
Autoland Patchset:
	Patches: 590513
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/6ad4c8d89359
Try run started, revision 6ad4c8d89359. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=6ad4c8d89359
Try run for 6ad4c8d89359 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=6ad4c8d89359
Results (out of 209 total builds):
    success: 187
    warnings: 22
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-6ad4c8d89359
Whiteboard: [mentor=jdm][lang=js][autoland-in-queue] → [mentor=jdm][lang=js]
https://hg.mozilla.org/mozilla-central/rev/28e55051da13
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.