684724 - Locale picker is displayed after changing the language pack for the first time

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Cristian Nicolae (:xti)]

Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110905
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2

Steps to reproduce:
1. Open Fennec App
2. Go to Preferences -> Language
3. Choose any language from the list (ex: Italian)
4. Restart the app

Expected result:
Fennec restarts and the new language pack is applied. 

Actual result:
After Fennec restarts, the locale picker is displayed.

Note:
This issue occurs only for the first time when the language pack is changed.

Comment 1

[Aaron Train [:aaronmt]]

Sounds like either a regression from bug 668838, or rather intended with the new workflow with the patch and landing of that bug.

Comment 2

[Aaron Train [:aaronmt]]

Wes, if this intended, please remove the blocking bug 668838, and denote this bug as invalid.

Comment 3

[Wesley Johnston (:wesj)]

This was not intentional, but (I think) was fallout from bug 675252. We are now setting a user selected pref, but not updating the stored buildid:

http://mxr.mozilla.org/mozilla-central/source/mobile/components/BrowserCLH.js#127

I think it will be fixed by bug 658278 which will force us to use the new locale picker in the prefs pane, and which should then update the buildid. Keeping this around until that can be confirmed (or we decide not to check that in and instead need a fix here).

Comment 4

[Wesley Johnston (:wesj)]

This should be fixed now.

Comment 5

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20110927
Firefox/10.0a1 Fennec/10.0a1
Device: Acer ICONIA A500
OS: Android 3.1