684770 - Attributes are not persisted correctly, if the tab is never restored

Status: UNCONFIRMED

(Firefox :: Session Restore, defect)

Description

[ithinc]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:6.0.1) Gecko/20100101 Firefox/6.0.1
Build ID: 20110830092941

Steps to reproduce:

Similar to bug 607016, but happens on the attributes that are requested to persist with persistTabAttribute.

1. Set restore_on_demand = true (max_concurrent_tabs = 0)
2. Open some tabs and restart Firefox
3. Execute in JS shell:
gBrowser.selectedTab.previousSibling.setAttribute("dummy", true);
Cc["@mozilla.org/browser/sessionstore;1"]
.getService(Ci.nsISessionStore)
.persistTabAttribute("dummy");

4. Restart Firefox and check the "dummy" attribute
gBrowser.selectedTab.previousSibling.hasAttribute("dummy");



Actual results:

The "dummy" attribute on the unloaded tab is not saved.


Expected results:

The "dummy" attribute should be saved.

Comment 1

[ithinc]

Attachment: patch

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 692679 [details] [diff] [review]
patch

Review of attachment 692679 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks for the patch! Should be simple to write a test for this, no?

Comment 3

[ithinc]

Attachment: patch v2

Added testcase.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 695480 [details] [diff] [review]
patch v2

Review of attachment 695480 [details] [diff] [review]:
-----------------------------------------------------------------

The 'pending' attribute assertions fail when running the full test suite. The test completely fails when run in single mode. Sorry I currently don't have the time to look into why exactly it is failing. Thank you for writing the test and it would be great if you could take a look at the failures.

Comment 5

[ithinc]

What I can think of only is that browser.sessionstore.restore_on_demand is turned off. Is this the case?