Closed Bug 684808 Opened 9 years ago Closed 9 years ago

Warning: reference to undefined property this.init

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set
normal

Tracking

(seamonkey2.4 fixed, seamonkey2.5 fixed, seamonkey2.6 fixed)

RESOLVED FIXED
seamonkey2.4
Tracking Status
seamonkey2.4 --- fixed
seamonkey2.5 --- fixed
seamonkey2.6 --- fixed

People

(Reporter: neil, Assigned: neil)

Details

(Whiteboard: [transplant changeset 7b2cf49b4829 from c-c])

Attachments

(1 file)

Warning: reference to undefined property this.init
Source File: chrome://navigator/content/linkToolbarHandler.js
Line: 59

This has probably been around since the year dot, but strict warnings in event handlers probably didn't get reported before :-( As a result, the (capturing!) event handler never gets removed, and executes for every page, frame, image...
Attached patch Proposed patchSplinter Review
Rather than trying to fix the event handling, I thought I'd eliminate it.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #558428 - Flags: review?(iann_bugzilla)
Attachment #558428 - Flags: review?(iann_bugzilla) → review+
Pushed changeset 7b2cf49b4829 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 558428 [details] [diff] [review]
Proposed patch

Don't know when the warning message started spamming the error console, but the code was bogus anyway and this will speed up the link toolbar.
Attachment #558428 - Flags: approval-comm-beta?
Attachment #558428 - Flags: approval-comm-aurora?
Attachment #558428 - Flags: approval-comm-beta?
Attachment #558428 - Flags: approval-comm-beta+
Attachment #558428 - Flags: approval-comm-aurora?
Attachment #558428 - Flags: approval-comm-aurora+
Keywords: checkin-needed
Whiteboard: [transplant changeset 7b2cf49b4829 from c-c]
You need to log in before you can comment on or make changes to this bug.