Closed
Bug 684808
Opened 13 years ago
Closed 13 years ago
Warning: reference to undefined property this.init
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(seamonkey2.4 fixed, seamonkey2.5 fixed, seamonkey2.6 fixed)
RESOLVED
FIXED
seamonkey2.4
People
(Reporter: neil, Assigned: neil)
Details
(Whiteboard: [transplant changeset 7b2cf49b4829 from c-c])
Attachments
(1 file)
|
1.55 KB,
patch
|
iannbugzilla
:
review+
Callek
:
approval-comm-aurora+
Callek
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Warning: reference to undefined property this.init
Source File: chrome://navigator/content/linkToolbarHandler.js
Line: 59
This has probably been around since the year dot, but strict warnings in event handlers probably didn't get reported before :-( As a result, the (capturing!) event handler never gets removed, and executes for every page, frame, image...
|
Assignee | |
Comment 1•13 years ago
|
||
Rather than trying to fix the event handling, I thought I'd eliminate it.
Attachment #558428 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Pushed changeset 7b2cf49b4829 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 558428 [details] [diff] [review]
Proposed patch
Don't know when the warning message started spamming the error console, but the code was bogus anyway and this will speed up the link toolbar.
Attachment #558428 -
Flags: approval-comm-beta?
Attachment #558428 -
Flags: approval-comm-aurora?
|
||
Updated•13 years ago
|
Attachment #558428 -
Flags: approval-comm-beta?
Attachment #558428 -
Flags: approval-comm-beta+
Attachment #558428 -
Flags: approval-comm-aurora?
Attachment #558428 -
Flags: approval-comm-aurora+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [transplant changeset 7b2cf49b4829 from c-c]
|
||
Comment 4•13 years ago
|
||
Pushed:
http://hg.mozilla.org/releases/comm-aurora/rev/723da19f3ca5
http://hg.mozilla.org/releases/comm-beta/rev/d3ced72c9a7c
status-seamonkey2.4:
--- → fixed
status-seamonkey2.5:
--- → fixed
status-seamonkey2.6:
--- → fixed
Keywords: checkin-needed
Target Milestone: --- → seamonkey2.4
You need to log in
before you can comment on or make changes to this bug.
Description
•