Warning: reference to undefined property this.init

RESOLVED FIXED in seamonkey2.4

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: neil, Assigned: neil)

Tracking

Trunk
seamonkey2.4

SeaMonkey Tracking Flags

(seamonkey2.4 fixed, seamonkey2.5 fixed, seamonkey2.6 fixed)

Details

(Whiteboard: [transplant changeset 7b2cf49b4829 from c-c])

Attachments

(1 attachment)

Assignee

Description

8 years ago
Warning: reference to undefined property this.init
Source File: chrome://navigator/content/linkToolbarHandler.js
Line: 59

This has probably been around since the year dot, but strict warnings in event handlers probably didn't get reported before :-( As a result, the (capturing!) event handler never gets removed, and executes for every page, frame, image...
Assignee

Comment 1

8 years ago
Rather than trying to fix the event handling, I thought I'd eliminate it.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #558428 - Flags: review?(iann_bugzilla)

Updated

8 years ago
Attachment #558428 - Flags: review?(iann_bugzilla) → review+
Assignee

Comment 2

8 years ago
Pushed changeset 7b2cf49b4829 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee

Comment 3

8 years ago
Comment on attachment 558428 [details] [diff] [review]
Proposed patch

Don't know when the warning message started spamming the error console, but the code was bogus anyway and this will speed up the link toolbar.
Attachment #558428 - Flags: approval-comm-beta?
Attachment #558428 - Flags: approval-comm-aurora?
Attachment #558428 - Flags: approval-comm-beta?
Attachment #558428 - Flags: approval-comm-beta+
Attachment #558428 - Flags: approval-comm-aurora?
Attachment #558428 - Flags: approval-comm-aurora+
Assignee

Updated

8 years ago
Keywords: checkin-needed
Whiteboard: [transplant changeset 7b2cf49b4829 from c-c]
You need to log in before you can comment on or make changes to this bug.