684825 - ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr' trying to get experimental-webgl context with options

Status: RESOLVED FIXED

Description

[[e-mail]]

nsHTMLCanvasElement::GetContext creates a hash property bag to convert its context options into an nsIProperties object. Unfortunately a hash property bag has inherits multiply from nsIProperties and the wrong one gets put in the second nsCOMPtr. (I'm not sure why it uses two nsCOMPtrs in the first place.)

Comment 1

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

I've been meaning to file this for some time, thanks for doing that.

Comment 2

[[e-mail]]

Created attachment 559410 [details] [diff] [review]
Proposed patch

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 559410 [details] [diff] [review]
Proposed patch

Looks fine to me. Benoit should probably look, but I think it's fine for his review to come after landing.

Comment 4

[[e-mail]]

Pushed changeset cb79942d0feb to mozilla-central.

Comment 5

[[e-mail]]

Sorry, I should have said changeset afe75f8431ad of course.

Comment 6

[:Ms2ger (⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/afe75f8431ad

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 559410 [details] [diff] [review]
Proposed patch

I'm not a good reviewer for this code.