ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr' trying to get experimental-webgl context with options

RESOLVED FIXED

Status

()

Product:
Core
Component:
Canvas: WebGL
Type:
defect
Status:
RESOLVED FIXED
Opened:
8 years ago
Updated:
8 years ago

People

(Reporter: neil, Unassigned)

Tracking

({assertion})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Proposed patch
2.51 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
nsHTMLCanvasElement::GetContext creates a hash property bag to convert its context options into an nsIProperties object. Unfortunately a hash property bag has inherits multiply from nsIProperties and the wrong one gets put in the second nsCOMPtr. (I'm not sure why it uses two nsCOMPtrs in the first place.)
I've been meaning to file this for some time, thanks for doing that.
Attachment #559410 - Flags: review?(jmuizelaar)
Comment on attachment 559410 [details] [diff] [review]
Proposed patch

Looks fine to me. Benoit should probably look, but I think it's fine for his review to come after landing.
Attachment #559410 - Flags: review?(jmuizelaar)
Attachment #559410 - Flags: review?(bjacob)
Attachment #559410 - Flags: review+
Pushed changeset cb79942d0feb to mozilla-central.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Sorry, I should have said changeset afe75f8431ad of course.
Comment on attachment 559410 [details] [diff] [review]
Proposed patch

I'm not a good reviewer for this code.
Attachment #559410 - Flags: review?(bjacob)
You need to log in before you can comment on or make changes to this bug.