Note: There are a few cases of duplicates in user autocompletion which are being worked on.

ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr' trying to get experimental-webgl context with options

RESOLVED FIXED

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Unassigned)

Tracking

({assertion})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
nsHTMLCanvasElement::GetContext creates a hash property bag to convert its context options into an nsIProperties object. Unfortunately a hash property bag has inherits multiply from nsIProperties and the wrong one gets put in the second nsCOMPtr. (I'm not sure why it uses two nsCOMPtrs in the first place.)
I've been meaning to file this for some time, thanks for doing that.
(Reporter)

Comment 2

6 years ago
Created attachment 559410 [details] [diff] [review]
Proposed patch
Attachment #559410 - Flags: review?(jmuizelaar)
Comment on attachment 559410 [details] [diff] [review]
Proposed patch

Looks fine to me. Benoit should probably look, but I think it's fine for his review to come after landing.
Attachment #559410 - Flags: review?(jmuizelaar)
Attachment #559410 - Flags: review?(bjacob)
Attachment #559410 - Flags: review+
(Reporter)

Comment 4

6 years ago
Pushed changeset cb79942d0feb to mozilla-central.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

6 years ago
Sorry, I should have said changeset afe75f8431ad of course.
https://hg.mozilla.org/mozilla-central/rev/afe75f8431ad
Comment on attachment 559410 [details] [diff] [review]
Proposed patch

I'm not a good reviewer for this code.
Attachment #559410 - Flags: review?(bjacob)
You need to log in before you can comment on or make changes to this bug.