684900 - libffi assembly files are not built with debug symbols

Status: NEW

(Core :: js-ctypes, enhancement, P3)

Description

[(not currently active) Ted Mielczarek]

While testing some stackwalking code, I found that there was a libffi function for which I didn't have debug symbols. It turns out that the assembly files for libffi are built without debug info, despite the fact that they contain proper debug annotations. Getting "-g" into the compile line is probably sufficient, but making that happen in the painful depths of Automake might be tricky.

Comment 1

[(not currently active) Ted Mielczarek]

I fixed this with a simple Makefile.am change, I submitted a pull request upstream:
https://github.com/atgreen/libffi/pull/3

Comment 2

[(not currently active) Ted Mielczarek]

That change landed upstream:
https://github.com/atgreen/libffi/commit/8c01954c50bf8ef2e00a3db166060a1b8f83a20d

but it didn't really fix my issue. I still don't get useful symbols for the functions in the assembly files. glandium says it's just missing some debug annotations and he might be able to fix that.

Comment 3

[Bobby Holley (:bholley)]

If you want this stuff in our tree soon, you'll probably want to add a patch to our copy as well - not sure when we're going to do another libffi drop.

Comment 4

[(not currently active) Ted Mielczarek]

Yeah, we'll sort that out once we actually get the problem fixed. :) Note that libffi has released a 3.0.10 in the meantime, which might subsume some of our local patches.