685050 - [build failed] comm-central MIDL flag is different to mozilla-central on win64 build

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[ABE Hiroki (:hATrayflood)]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:6.0.1) Gecko/20100101 Firefox/6.0.1
Build ID: 20110830092941

Steps to reproduce:

I tried to build comm-central with Bug 682788.
but I failed to build. following is build log.

make[7]: Entering directory `/f/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mailnews/mapi/mapihook/build'
dlldata.c
f:/mozilla-build/python/python2.6.exe -O f:/mozilla/nightly/comm-central/mozilla/build/cl.py cl -Fodlldata.obj -c  -DMOZILLA_INTERNAL_API -DMOZ_THUNDERBIRD=1 -DOSTYPE=\"WINNT6.1\" -DOSARCH=WINNT -DREGISTER_PROXY_DLL -DUNICODE -D_UNICODE -D_WIN32_WINNT=0x400 -I. -I/f/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build -I. -I../../../../mozilla/dist/include -I../../../../mozilla/dist/include/nsprpub  -If:/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mozilla/dist/include/nspr -If:/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mozilla/dist/include/nss        -TC -nologo -W3 -Gy -Fdgenerated.pdb  -DNDEBUG -DTRIMMED -O1 -MD            -FI ../../../../comm-config.h -DMOZILLA_CLIENT /f/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mailnews/mapi/mapihook/build/dlldata.c
dlldata.c

f:\mozilla\nightly\comm-central\obj-i686-pc-mingw32\mailnews\mapi\mapihook\build\../../../../comm-config.h(73) : warning C4005: '_WIN32_WINNT' : マクロが再定義されました。

        コマンド ラインの引数 : '_WIN32_WINNT' の前の定義を確認してください

msgMapi_p.c
f:/mozilla-build/python/python2.6.exe -O f:/mozilla/nightly/comm-central/mozilla/build/cl.py cl -FomsgMapi_p.obj -c  -DMOZILLA_INTERNAL_API -DMOZ_THUNDERBIRD=1 -DOSTYPE=\"WINNT6.1\" -DOSARCH=WINNT -DREGISTER_PROXY_DLL -DUNICODE -D_UNICODE -D_WIN32_WINNT=0x400 -I. -I/f/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build -I. -I../../../../mozilla/dist/include -I../../../../mozilla/dist/include/nsprpub  -If:/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mozilla/dist/include/nspr -If:/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mozilla/dist/include/nss        -TC -nologo -W3 -Gy -Fdgenerated.pdb  -DNDEBUG -DTRIMMED -O1 -MD            -FI ../../../../comm-config.h -DMOZILLA_CLIENT /f/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mailnews/mapi/mapihook/build/msgMapi_p.c
msgMapi_p.c

f:\mozilla\nightly\comm-central\obj-i686-pc-mingw32\mailnews\mapi\mapihook\build\../../../../comm-config.h(73) : warning C4005: '_WIN32_WINNT' : マクロが再定義されました。

        コマンド ラインの引数 : '_WIN32_WINNT' の前の定義を確認してください

msgMapi_i.c
f:/mozilla-build/python/python2.6.exe -O f:/mozilla/nightly/comm-central/mozilla/build/cl.py cl -FomsgMapi_i.obj -c  -DMOZILLA_INTERNAL_API -DMOZ_THUNDERBIRD=1 -DOSTYPE=\"WINNT6.1\" -DOSARCH=WINNT -DREGISTER_PROXY_DLL -DUNICODE -D_UNICODE -D_WIN32_WINNT=0x400 -I. -I/f/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build -I. -I../../../../mozilla/dist/include -I../../../../mozilla/dist/include/nsprpub  -If:/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mozilla/dist/include/nspr -If:/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mozilla/dist/include/nss        -TC -nologo -W3 -Gy -Fdgenerated.pdb  -DNDEBUG -DTRIMMED -O1 -MD            -FI ../../../../comm-config.h -DMOZILLA_CLIENT /f/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mailnews/mapi/mapihook/build/msgMapi_i.c
msgMapi_i.c

f:\mozilla\nightly\comm-central\obj-i686-pc-mingw32\mailnews\mapi\mapihook\build\../../../../comm-config.h(73) : warning C4005: '_WIN32_WINNT' : マクロが再定義されました。

        コマンド ラインの引数 : '_WIN32_WINNT' の前の定義を確認してください

/bin/sh /f/mozilla/nightly/comm-central/mozilla/build/msys-perl-wrapper /f/mozilla/nightly/comm-central/mozilla/config/version_win.pl -QUIET 1 -DEPTH ../../../../mozilla -TOPSRCDIR /f/mozilla/nightly/comm-central/mozilla -OBJDIR . -SRCDIR /f/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build -DISPNAME Shredder -APPVERSION 9.0a1 -MODNAME MapiProxy
Creating Resource file: module.res
rc.exe  -r -DMOZILLA_INTERNAL_API -DMOZ_THUNDERBIRD=1 -DOSTYPE=\"WINNT6.1\" -DOSARCH=WINNT -DREGISTER_PROXY_DLL -DUNICODE -D_UNICODE -D_WIN32_WINNT=0x400 -I. -I/f/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build -I. -I../../../../mozilla/dist/include -I../../../../mozilla/dist/include/nsprpub  -If:/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mozilla/dist/include/nspr -If:/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mozilla/dist/include/nss     -Fomodule.res /f/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mailnews/mapi/mapihook/build/module.rc
Microsoft (R) Windows (R) Resource Compiler Version 6.1.7600.16385

Copyright (C) Microsoft Corporation.  All rights reserved.


link -NOLOGO -DLL -OUT:MapiProxy.dll -PDB:MapiProxy.pdb -SUBSYSTEM:WINDOWS  dlldata.obj msgMapi_p.obj msgMapi_i.obj    ./module.res -MANIFESTUAC:NO -NXCOMPAT -DYNAMICBASE  -LIBPATH:../../../../mozilla/dist/lib -NODEFAULTLIB:msvcrt -NODEFAULTLIB:msvcrtd -NODEFAULTLIB:msvcprt -NODEFAULTLIB:msvcprtd -DEFAULTLIB:mozcrt -DEF:f:/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build/MapiProxy.def    kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib rpcrt4.lib  
f:/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build/MapiProxy.def(38) : warning LNK4017: DESCRIPTION ステートメントはターゲット プラットフォームでサポートされていません。無視しました。
f:/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build/MapiProxy.def : warning LNK4222: エクスポートされたシンボル 'DllGetClassObject' に序数を割り当てないでください。
f:/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build/MapiProxy.def : warning LNK4222: エクスポートされたシンボル 'DllCanUnloadNow' に序数を割り当てないでください。
f:/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build/MapiProxy.def : warning LNK4222: エクスポートされたシンボル 'DllRegisterServer' に序数を割り当てないでください。
f:/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build/MapiProxy.def : warning LNK4222: エクスポートされたシンボル 'DllUnregisterServer' に序数を割り当てないでください。
   ライブラリ MapiProxy.lib とオブジェクト MapiProxy.exp を作成中
dlldata.obj : error LNK2001: 外部シンボル "msgMapi_ProxyFileInfo" は未解決です。
MapiProxy.dll : fatal error LNK1120: 外部参照 1 が未解決です。
make[7]: *** [MapiProxy.dll] Error 96

linker error caused by missing of MIDL flag.

make[7]: Entering directory `/f/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mailnews/mapi/mapihook/build'
Creating /f/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mailnews/mapi/mapihook/build/.deps
rm -f /f/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build/dlldata.c /f/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build/msgMapi_p.c /f/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build/msgMapi_i.c
midl   /f/mozilla/nightly/comm-central/mailnews/mapi/mapihook/build/msgMapi.idl
Microsoft (R) 32b/64b MIDL Compiler Version 7.00.0555 
Copyright (c) Microsoft Corporation. All rights reserved.
Processing f:\mozilla\nightly\comm-central\mailnews\mapi\mapihook\build\msgMapi.idl
msgMapi.idl
Processing C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\include\unknwn.idl
unknwn.idl
Processing C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\include\wtypes.idl
wtypes.idl
Processing C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\include\basetsd.h
basetsd.h
Processing C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\include\guiddef.h
guiddef.h
touch done_gen
f:/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mozilla/config/nsinstall.exe -m 644 msgMapi.h ../../../../mozilla/dist/include
make[7]: Leaving directory `/f/mozilla/nightly/comm-central/obj-i686-pc-mingw32/mailnews/mapi/mapihook/build'

Comment 1

[ABE Hiroki (:hATrayflood)]

Attachment: patch v1

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 558695 [details] [diff] [review]
patch v1

Yes lets get this landed. afaik no comm app supports win x64 yet, even in terms of "known to build" mode. But thats not going to stop me from letting anyone try to get it working.

implicit a=me for any branch (up to beta) you can prove the m-c copy of configure has this as well, if needed.

Comment 3

[Makoto Kato [:m_kato]]

landed to c-c
http://hg.mozilla.org/comm-central/rev/815d09a30892

(In reply to Justin Wood (:Callek) from comment #2)
> Comment on attachment 558695 [details] [diff] [review]
> patch v1
> 
> Yes lets get this landed. afaik no comm app supports win x64 yet, even in
> terms of "known to build" mode. But thats not going to stop me from letting
> anyone try to get it working.
> 
> implicit a=me for any branch (up to beta) you can prove the m-c copy of
> configure has this as well, if needed.

Since Win64 isn't official yet, we don't need this for branches.  This is only if using x86_amd64 version of toolchain.

Comment 4

[[e-mail]]

Ah yes, I had that part of bug 469654 ported locally, but forgot to file a bug.