Use a js::Vector for bytecode and srcnotes in JSCodeGenerator

RESOLVED WORKSFORME

Status

()

Core
JavaScript Engine
RESOLVED WORKSFORME
6 years ago
2 years ago

People

(Reporter: njn, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
JSCodeGenerator should use a js::Vector for its bytecode and srcnotes buffers, it would be much cleaner than managing the buffers explicitly.

I tried to do this previously, bug 684111 comment 10 explains why it's difficult.  That bug has a patch (attachment 558221 [details] [diff] [review]) for the bytecode buffer that works except for one annoying case.  The srcnotes buffer is harder and more annoying.
(Reporter)

Updated

5 years ago
Assignee: n.nethercote → general
(Assignee)

Updated

3 years ago
Assignee: general → nobody
(Reporter)

Comment 1

2 years ago
BytecodeEmitter has these:

> typedef Vector<jsbytecode, 0> BytecodeVector;
> typedef Vector<jssrcnote, 0> SrcNotesVector;

So I think this was done a long time ago.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.