Closed Bug 685130 Opened 11 years ago Closed 11 years ago

Should build libffi as thumb when compiling for ARM

Categories

(Core :: js-ctypes, defect)

Product:
Core
Component:
js-ctypes
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla9

People

(Reporter: ted, Assigned: glandium)

Details

Attachments

(1 file)

Build libffi with the same flags as the rest
1.07 KB, patch
ted
: review+
Details | Diff | Splinter Review 
Currently libffi is built as ARM instead of thumb. The source supports thumb, we just need to pass the right compile flags.
As mentioned on IRC, I think removing these 3 lines should work:
http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#5633
It looks like this has the desired effect.
Attachment #558795 - Flags: review?(ted.mielczarek)
Attachment #558795 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → mh+mozilla
https://hg.mozilla.org/mozilla-central/rev/ad202468df63
Target Milestone: --- → mozilla9
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.