Should build libffi as thumb when compiling for ARM

RESOLVED FIXED in mozilla9

Status

()

Core
js-ctypes
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ted, Assigned: glandium)

Tracking

Trunk
mozilla9
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Currently libffi is built as ARM instead of thumb. The source supports thumb, we just need to pass the right compile flags.
(Assignee)

Comment 1

6 years ago
As mentioned on IRC, I think removing these 3 lines should work:
http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#5633
(Assignee)

Comment 2

6 years ago
Created attachment 558795 [details] [diff] [review]
Build libffi with the same flags as the rest

It looks like this has the desired effect.
Attachment #558795 - Flags: review?(ted.mielczarek)
(Reporter)

Updated

6 years ago
Attachment #558795 - Flags: review?(ted.mielczarek) → review+
(Reporter)

Updated

6 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/ad202468df63
Target Milestone: --- → mozilla9
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.