685156 - WebGL's hint function incorrectly generates an invalid enumeration

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Patrick Cozzi]

Attachment: Testcase to reproduce the problem

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110622232440

Steps to reproduce:

Made valid calls to WebGL's hint function from JavaScript, e.g.:

   gl.hint(gl.GENERATE_MIPMAP_HINT, gl.DONT_CARE);


Actual results:

The call generated an gl.INVALID_ENUM.


Expected results:

No error should be generated, e.g., calling gl.getError() should return gl.NO_ERROR, and WeGL's mipmap hint state should change.

Comment 1

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (Windows NT 5.1; rv:9.0a1) Gecko/20110919 Firefox/9.0a1
Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110918 Firefox/9.0a1
Mozilla/5.0 (Windows NT 6.1; rv:9.0a1) Gecko/20110919 Firefox/9.0a1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:9.0a1) Gecko/20110915 Firefox/9.0a1

Reproducible on Ubuntu 11.04, Mac OS 10.7, Windows XP and 7 using the test case provided in Comment 0. Invalid enumeration error is generated for all functions, contrary to other browsers.

Comment 2

[Kelsey Gilbert [:jgilbert]]

This appears to be a regression from bug 684853.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: webgl.hint() must accept GENERATE_MIPMAP_HINT

Adds GENERATE_MIPMAP_HINT to the 'list' of acceptable inputs.
Try run:
https://tbpl.mozilla.org/?tree=Try&rev=29a579aab730

Comment 4

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ace3d2af4b7

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/1ace3d2af4b7