685183 - Remove unneeded wait after profile creation

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Remove unneeded wait for profile creation

InitializeNewProfile already waits for the process to exit so we shouldn't need to do any additional waiting here.

Comment 1

[Jeff Hammel]

Is this really a Mac-only issue?

Comment 2

[Jeff Hammel]

Comment on attachment 558834 [details] [diff] [review]
Remove unneeded wait for profile creation

works for me; did you do any testing?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

(In reply to Jeff Hammel [:jhammel] from comment #2)
> Comment on attachment 558834 [details] [diff] [review]
> Remove unneeded wait for profile creation
> 
> works for me; did you do any testing?

Yep. This did not cause any problems for me in standalone talos.

Comment 4

[Jeff Hammel]

This needs to be staged but I'm glad to take the change. Thanks for the patch!

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

landed on talos:
http://hg.mozilla.org/build/talos/rev/290a6a2353fe

Comment 6

[Ed Morley [:emorley]]

Could this be the cause of the talos failures that have started appearing today on both inbound and m-c?

eg:
{
rm: symbols/certutil: Input/output error
rm: symbols/crashreporter: Input/output error
rm: symbols/firefox: Input/output error
rm: symbols/firefox-bin: Input/output error
rm: symbols/GoodPlugin: Input/output error
rm: symbols/libalerts_s.dylib: Input/output error
talos
rm: symbols/libbrowsercomps.dylib: Input/output error
rm: symbols: Directory not empty
}
https://tbpl.mozilla.org/php/getParsedLog.php?id=8400988&tree=Mozilla-Inbound

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

no, this hasn't been deployed, just passed staging and checked in.

Those errors look like disk issues?  maybe permissions or out of space