685326 - Add Round{In,Out} to BaseRect

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Joe Drew (not getting mail)]

Attachment: Add BaseRect::Round{In,Out}

Just like we have gfxRect::RoundIn and RoundOut, we should have BaseRect::RoundIn and RoundOut.

Comment 1

[Bas Schouten (:bas.schouten)]

Comment on attachment 558975 [details] [diff] [review]
Add BaseRect::Round{In,Out}

Review of attachment 558975 [details] [diff] [review]:
-----------------------------------------------------------------

I don't -really- care. It doesn't make a whole lot of sense for Int though. I'm fine with this, but asking Roc what he thinks.

Comment 2

[Joe Drew (not getting mail)]

It doesn't really matter to me where Round* goes; I only added it to BaseRect because the similar ScaleRound* functions were on it. Scale obviously would do something on IntRects, whereas Round wouldn't, but it seemed natural enough anyways.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 558975 [details] [diff] [review]
Add BaseRect::Round{In,Out}

Review of attachment 558975 [details] [diff] [review]:
-----------------------------------------------------------------

Seems OK. Shouldn't you remove RoundOut/RoundIn from gfxRect? Why not add Round() here too?

I think IntRect should declare RoundOut/RoundIn/Round and just define them to be noops.

Comment 4

[Joe Drew (not getting mail)]

Attachment: move Round{,In,Out} to BaseRect, remove it from gfxRect

Don't know precisely how I missed the fact that gfxRect is derived from BaseRect. Anyways, this removes the gfxRect versions, and adds an empty version to IntRect. These functions aren't virtual, but it doesn't matter since they should be no-ops on integers, and we always operate on the concrete class anyways.

Comment 5

[Joe Drew (not getting mail)]

Bas, review ping?

Comment 6

[Joe Drew (not getting mail)]

Er, whoops - Bas wasn't cc'd.

Bas, review ping?

Comment 7

[Bas Schouten (:bas.schouten)]

Comment on attachment 559545 [details] [diff] [review]
move Round{,In,Out} to BaseRect, remove it from gfxRect

Review of attachment 559545 [details] [diff] [review]:
-----------------------------------------------------------------

r+ which change discussed on IRC.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e6705f49eaaa