685357 - [Downloads Panel] Mochitest failure in editor/libeditor/html/tests/test_bug549262.html

Status: RESOLVED DUPLICATE of bug 726444

(Firefox :: General, defect)

Description

[:Paolo Amadini]

Attachment: Fix handling of the space and return keys in the main browser window

In the version of the patch in bug 564934 that landed on the UX branch, the
<key> elements in downloadsOverlay.xul are eating the space key, that normally
scrolls down the page. This patch replaces the elements with event handlers on
the downloads list.

Comment 1

[:Paolo Amadini]

Now running on tryserver:

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=4f7922e2ae6f

Comment 2

[:Paolo Amadini]

(In reply to Paolo Amadini from comment #1)
> Now running on tryserver:
> 
> https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=4f7922e2ae6f

Succeeded :-)

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 558995 [details] [diff] [review]
Fix handling of the space and return keys in the main browser window

Ehsan, I'm not sure if this patch is bitrotted, but it looks to have been just sitting here without a review request attached. Can you take a look at it and see if we should take this?

Comment 4

[:Paolo Amadini]

Comment on attachment 558995 [details] [diff] [review]
Fix handling of the space and return keys in the main browser window

Oh, this is actually a fix on top of bug 564934 and bug 663772. This already
landed on the UX branch, will be reviewed together with the other patches.

Comment 5

[:Paolo Amadini]

The patch on this bug is now included as part of the patch in bug 726444. Any
pending issue here should have already been filed as one of the bug's follow-ups.