Closed Bug 685404 Opened 9 years ago Closed 9 years ago

nsAutoTArray-ize callers to nsDisplayList::HitTest

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla9

People

(Reporter: roc, Assigned: roc)

Details

(Whiteboard: [MemShrink])

Attachments

(1 file)

fix
2.24 KB, patch
tnikkel
: review+
Details | Diff | Splinter Review 
No description provided.
Attached patch fix — — Splinter Review
Attachment #559040 - Flags: review?(tnikkel)
Comment on attachment 559040 [details] [diff] [review]
fix

So the idea is to allocate a reasonable amount of space at the start instead of allocating later in smaller pieces?
The idea is to have an 8-element array on the stack so we don't have to heap-allocate at all.
(which is slower and could cause fragmentation)
Attachment #559040 - Flags: review?(tnikkel) → review+
Whiteboard: checkin-needed
Could we enforce this by making the callee signatures explicitly list an nsTArray, just in case another caller gets added?  And if so, do we want to?
http://hg.mozilla.org/integration/mozilla-inbound/rev/aea08d37a22b
Whiteboard: checkin-needed → [MemShrink]
We could enforce it, but it's probably not worth it.
http://hg.mozilla.org/mozilla-central/rev/aea08d37a22b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.