Comment 1 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-09-07 21:23:27 PDT

Created attachment 559040 [details] [diff] [review]
fix

Comment 2 Timothy Nikkel (:tnikkel) 2011-09-07 21:56:14 PDT

Comment on attachment 559040 [details] [diff] [review]
fix

So the idea is to allocate a reasonable amount of space at the start instead of allocating later in smaller pieces?

Comment 3 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-09-07 22:00:53 PDT

The idea is to have an 8-element array on the stack so we don't have to heap-allocate at all.

Comment 4 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-09-07 22:01:15 PDT

(which is slower and could cause fragmentation)

Comment 5 Boris Zbarsky [:bz] (TPAC) 2011-09-08 07:07:01 PDT

Could we enforce this by making the callee signatures explicitly list an nsTArray, just in case another caller gets added?  And if so, do we want to?

Comment 6 :Ehsan Akhgari 2011-09-08 14:31:27 PDT

http://hg.mozilla.org/integration/mozilla-inbound/rev/aea08d37a22b

Comment 7 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-09-08 22:34:21 PDT

We could enforce it, but it's probably not worth it.

Comment 8 :Ehsan Akhgari 2011-09-09 07:41:06 PDT

http://hg.mozilla.org/mozilla-central/rev/aea08d37a22b