nsAutoTArray-ize callers to nsDisplayList::HitTest

RESOLVED FIXED in mozilla9

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
mozilla9
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

([MemShrink])

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 559040 [details] [diff] [review]
fix
Attachment #559040 - Flags: review?(tnikkel)
Comment on attachment 559040 [details] [diff] [review]
fix

So the idea is to allocate a reasonable amount of space at the start instead of allocating later in smaller pieces?
The idea is to have an 8-element array on the stack so we don't have to heap-allocate at all.
(which is slower and could cause fragmentation)
Attachment #559040 - Flags: review?(tnikkel) → review+
Whiteboard: checkin-needed
Could we enforce this by making the callee signatures explicitly list an nsTArray, just in case another caller gets added?  And if so, do we want to?

Comment 6

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/aea08d37a22b
Whiteboard: checkin-needed → [MemShrink]
We could enforce it, but it's probably not worth it.

Comment 8

6 years ago
http://hg.mozilla.org/mozilla-central/rev/aea08d37a22b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.