Status
()
People
(Reporter: roc, Assigned: roc)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
(Whiteboard: [MemShrink])
Attachments
(1 attachment)
|
2.24 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
| Comment hidden (empty) |
|
(Assignee) | |
Comment 1•8 years ago
|
||
Attachment #559040 -
Flags: review?(tnikkel)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 559040 [details] [diff] [review] fix So the idea is to allocate a reasonable amount of space at the start instead of allocating later in smaller pieces?
|
|
(Assignee) | |
Comment 3•8 years ago
|
||
The idea is to have an 8-element array on the stack so we don't have to heap-allocate at all.
|
|
(Assignee) | |
Comment 4•8 years ago
|
||
(which is slower and could cause fragmentation)
|
|
||
Updated•8 years ago
|
Attachment #559040 -
Flags: review?(tnikkel) → review+
|
|
(Assignee) | |
Updated•8 years ago
|
Whiteboard: checkin-needed
|
||
Comment 5•8 years ago
|
||
Could we enforce this by making the callee signatures explicitly list an nsTArray, just in case another caller gets added? And if so, do we want to?
|
||
Comment 6•8 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/aea08d37a22b
Whiteboard: checkin-needed → [MemShrink]
|
|
(Assignee) | |
Comment 7•8 years ago
|
||
We could enforce it, but it's probably not worth it.
|
|
||
Comment 8•8 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/aea08d37a22b
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.