685404 - nsAutoTArray-ize callers to nsDisplayList::HitTest

Status: RESOLVED FIXED

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Created attachment 559040 [details] [diff] [review]
fix

Comment 2

[Timothy Nikkel (:tnikkel)]

Comment on attachment 559040 [details] [diff] [review]
fix

So the idea is to allocate a reasonable amount of space at the start instead of allocating later in smaller pieces?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The idea is to have an 8-element array on the stack so we don't have to heap-allocate at all.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(which is slower and could cause fragmentation)

Comment 5

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

Could we enforce this by making the callee signatures explicitly list an nsTArray, just in case another caller gets added?  And if so, do we want to?

Comment 6

[:Ehsan Akhgari (needinfo please, extremely long backlog)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/aea08d37a22b

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We could enforce it, but it's probably not worth it.

Comment 8

[:Ehsan Akhgari (needinfo please, extremely long backlog)]

http://hg.mozilla.org/mozilla-central/rev/aea08d37a22b