Closed
Bug 685404
Opened 14 years ago
Closed 14 years ago
nsAutoTArray-ize callers to nsDisplayList::HitTest
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: roc, Assigned: roc)
Details
(Whiteboard: [MemShrink])
Attachments
(1 file)
2.24 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #559040 -
Flags: review?(tnikkel)
Comment 2•14 years ago
|
||
Comment on attachment 559040 [details] [diff] [review]
fix
So the idea is to allocate a reasonable amount of space at the start instead of allocating later in smaller pieces?
Assignee | ||
Comment 3•14 years ago
|
||
The idea is to have an 8-element array on the stack so we don't have to heap-allocate at all.
Assignee | ||
Comment 4•14 years ago
|
||
(which is slower and could cause fragmentation)
Updated•14 years ago
|
Attachment #559040 -
Flags: review?(tnikkel) → review+
Assignee | ||
Updated•14 years ago
|
Whiteboard: checkin-needed
![]() |
||
Comment 5•14 years ago
|
||
Could we enforce this by making the callee signatures explicitly list an nsTArray, just in case another caller gets added? And if so, do we want to?
Comment 6•14 years ago
|
||
Whiteboard: checkin-needed → [MemShrink]
Assignee | ||
Comment 7•14 years ago
|
||
We could enforce it, but it's probably not worth it.
Comment 8•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•