Last Comment Bug 685435 - Remove some unneeded multithread support
: Remove some unneeded multithread support
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: ImageLib (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla9
Assigned To: Jeff Muizelaar [:jrmuizel]
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-07 23:47 PDT by Jeff Muizelaar [:jrmuizel]
Modified: 2011-09-21 02:51 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove mCacheId and associated code (9.34 KB, patch)
2011-09-07 23:47 PDT, Jeff Muizelaar [:jrmuizel]
joe: review+
Details | Diff | Splinter Review

Description Jeff Muizelaar [:jrmuizel] 2011-09-07 23:47:46 PDT
Created attachment 559054 [details] [diff] [review]
Remove mCacheId and associated code

imglib should only be called from the main thread which implies that we shouldn't need this stuff.

I'll follow up with a patch that removes IsReusable()
Comment 1 Joe Drew (not getting mail) 2011-09-08 12:32:35 PDT
Comment on attachment 559054 [details] [diff] [review]
Remove mCacheId and associated code

Review of attachment 559054 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpr0n/src/imgLoader.cpp
@@ +1062,3 @@
>  
>      // If the existing request is currently loading, or loading on a different
>      // thread, we'll leave it be, and not put this new entry into the cache.

There's comments about "loading on a different thread" or "different event queue" left over here. They should all be removed.
Comment 2 Marco Bonardo [::mak] 2011-09-21 02:51:19 PDT
https://hg.mozilla.org/mozilla-central/rev/b80b4d52cd14

Note You need to log in before you can comment on or make changes to this bug.