685466 - [element.onSecurityChange is not a function] on every tab change

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[H. Hofer]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:9.0a1) Gecko/20110907 Firefox/9.0a1 SeaMonkey/2.6a1
Build ID: 20110907003046

Steps to reproduce:

Changing tabs in trunk build (ID: 20110907003046).


Actual results:

Error console entries on every tab change:

> Error: element.onSecurityChange is not a function
> Source File: chrome://navigator/content/tabbrowser.xml
> Line: 892

I don't know of any other consequences, but looking at the code, it seems some things might get missed.
I'm pretty sure this didn't happen on yesterday's build and it sure doesn't happen on 2.4b1.

Comment 1

[H. Hofer]

This seems to be caused by the latest development version of RequestPolicy.
(https://addons.mozilla.org/en-US/seamonkey/addon/requestpolicy/)

I'm setting this as invalid an will contact the author. Sorry!

Comment 2

[Philip Chee]

Reopening due to Mozillazine thread:
http://forums.mozillazine.org/viewtopic.php?p=11227331#p11227331

"Our tabbrowser implementation is separate. We usually try to keep the API in sync with Firefox and indeed we did make all events optional, but we missed one code path".

Comment 3

[Philip Chee]

Attachment: Patch v1.0 onSecurityChange should be optional.

https://developer.mozilla.org/en/Code_snippets/Progress_Listeners

"Starting in Gecko 2.0 (Firefox 4 / Thunderbird 3.3 / SeaMonkey 2.1) , all events are optional. The tabbrowser only notifies you of the events for which you provide a callback."

Comment 4

[[e-mail]]

Comment on attachment 560300 [details]
Patch v1.0 onSecurityChange should be optional.

>                   element.onLocationChange(aWebProgress, aRequest, aLocation);
Should this be optional too?

>+                  if (aSecurityUI && ("onSecurityChange" in element))
Nit: unnecessary ()s. (Only needed for the !("foo" in bar) case.)

Comment 5

[Philip Chee]

Attachment: Patch v1.1 onLocationChange should be optional too r=Neil.

>>                   element.onLocationChange(aWebProgress, aRequest, aLocation);
> Should this be optional too?
I suppose so. Done.

>>+                  if (aSecurityUI && ("onSecurityChange" in element))
> Nit: unnecessary ()s. (Only needed for the !("foo" in bar) case.)
Fixed.

Comment 6

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/cb68addedf54

Comment 7

[Philip Chee]

Comment on attachment 560349 [details] [diff] [review]
Patch v1.1 onLocationChange should be optional too r=Neil.

Request approval. Affects extensions like Request Policy which expect tabbrowser events to be optional as documented in developer.mozilla.org.

Comment 8

[Philip Chee]

Pushed:
http://hg.mozilla.org/releases/comm-aurora/rev/b1fa151ad169
http://hg.mozilla.org/releases/comm-beta/rev/5b983ed2ca5a