685518 - Shouldn't taint the canvas when drawing images with @crossorigin into it

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

For some reason this wasn't done in bug 664299 and followups, and since Chrome did implement this, people are hitting it as a problem now....

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Look at the image CORS mode for drawImage into a canvas 2d context.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Move the crossorigin webgl test to a saner location so I can add cross-origin non-webgl tests.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Add crossorigin 2d canvas tests.

Comment 4

[Boris Zbarsky [:bzbarsky]]

    http://hg.mozilla.org/integration/mozilla-inbound/rev/cb9eced21ea1
    http://hg.mozilla.org/integration/mozilla-inbound/rev/5946c1288127
    http://hg.mozilla.org/integration/mozilla-inbound/rev/7dfaccb430c3

Comment 5

[Justin Wood (:Callek)]

(In reply to Boris Zbarsky (:bz) from comment #4)
>     http://hg.mozilla.org/integration/mozilla-inbound/rev/cb9eced21ea1
>     http://hg.mozilla.org/integration/mozilla-inbound/rev/5946c1288127
>     http://hg.mozilla.org/integration/mozilla-inbound/rev/7dfaccb430c3

Now on m-c

Comment 6

[Eric Shepherd [:sheppy]]

Docs updated:

https://developer.mozilla.org/en/DOM/CanvasRenderingContext2D#drawImage%28%29
https://developer.mozilla.org/en/Canvas_tutorial/Using_images#Using_images_from_other_domains

Also cleaned up:

https://developer.mozilla.org/en/CORS_Enabled_Image
https://developer.mozilla.org/en/HTML/CORS_settings_attributes

And mentioned on Firefox 9 for developers.