Shouldn't taint the canvas when drawing images with @crossorigin into it

RESOLVED FIXED in mozilla9

Status

()

Core
Canvas: 2D
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

({dev-doc-complete})

unspecified
mozilla9
x86
Mac OS X
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

For some reason this wasn't done in bug 664299 and followups, and since Chrome did implement this, people are hitting it as a problem now....
Depends on: 664299
Created attachment 559211 [details] [diff] [review]
part 1.  Look at the image CORS mode for drawImage into a canvas 2d context.
Attachment #559211 - Flags: review?(roc)
Created attachment 559212 [details] [diff] [review]
part 2.  Move the crossorigin webgl test to a saner location so I can add cross-origin non-webgl tests.
Attachment #559212 - Flags: review?(roc)
Created attachment 559213 [details] [diff] [review]
part 3.  Add crossorigin 2d canvas tests.
Attachment #559213 - Flags: review?(roc)
Assignee: nobody → bzbarsky
Priority: -- → P1
Whiteboard: [need review]
Attachment #559211 - Flags: review?(roc) → review+
Attachment #559212 - Flags: review?(roc) → review+
Attachment #559213 - Flags: review?(roc) → review+
    http://hg.mozilla.org/integration/mozilla-inbound/rev/cb9eced21ea1
    http://hg.mozilla.org/integration/mozilla-inbound/rev/5946c1288127
    http://hg.mozilla.org/integration/mozilla-inbound/rev/7dfaccb430c3
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla9
(In reply to Boris Zbarsky (:bz) from comment #4)
>     http://hg.mozilla.org/integration/mozilla-inbound/rev/cb9eced21ea1
>     http://hg.mozilla.org/integration/mozilla-inbound/rev/5946c1288127
>     http://hg.mozilla.org/integration/mozilla-inbound/rev/7dfaccb430c3

Now on m-c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Keywords: dev-doc-needed
Docs updated:

https://developer.mozilla.org/en/DOM/CanvasRenderingContext2D#drawImage%28%29
https://developer.mozilla.org/en/Canvas_tutorial/Using_images#Using_images_from_other_domains

Also cleaned up:

https://developer.mozilla.org/en/CORS_Enabled_Image
https://developer.mozilla.org/en/HTML/CORS_settings_attributes

And mentioned on Firefox 9 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.