Last Comment Bug 685593 - remove unused argument gcKind from Debugger::markAllIteratively
: remove unused argument gcKind from Debugger::markAllIteratively
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Andrew McCreight [:mccr8]
:
Mentors:
Depends on:
Blocks: 653248
  Show dependency treegraph
 
Reported: 2011-09-08 10:33 PDT by Andrew McCreight [:mccr8]
Modified: 2011-09-10 16:15 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
remove the argument (2.85 KB, patch)
2011-09-08 10:47 PDT, Andrew McCreight [:mccr8]
jorendorff: review+
Details | Diff | Review

Description Andrew McCreight [:mccr8] 2011-09-08 10:33:34 PDT
The argument gcKind is unused, and it makes moving markAllIteratively out of MarkAndSweep into MarkRuntime, which I am considering doing as part of some GC cleanup, impossible.
Comment 1 Andrew McCreight [:mccr8] 2011-09-08 10:47:43 PDT
Created attachment 559216 [details] [diff] [review]
remove the argument

I haven't tested this yet, but it compiles, so there shouldn't be a problem.  I'll try server it before I land it.
Comment 2 Andrew McCreight [:mccr8] 2011-09-08 16:38:07 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/932366760659
Comment 3 Mozilla RelEng Bot 2011-09-08 23:50:55 PDT
Try run for 51307568846d is complete.
Detailed breakdown of the results available here:
    http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=51307568846d
Results (out of 146 total builds):
    exception: 2
    success: 141
    warnings: 2
    failure: 1
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/amccreight@mozilla.com-51307568846d
Comment 4 :Ehsan Akhgari (busy, don't ask for review please) 2011-09-09 07:43:22 PDT
http://hg.mozilla.org/mozilla-central/rev/932366760659
Comment 5 Mike Shaver (:shaver -- probably not reading bugmail closely) 2011-09-10 16:15:46 PDT
There is still no actual alliteration in this function, but I guess that's a separate bug.

Note You need to log in before you can comment on or make changes to this bug.