remove unused argument gcKind from Debugger::markAllIteratively

RESOLVED FIXED in mozilla9

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The argument gcKind is unused, and it makes moving markAllIteratively out of MarkAndSweep into MarkRuntime, which I am considering doing as part of some GC cleanup, impossible.
(Assignee)

Comment 1

6 years ago
Created attachment 559216 [details] [diff] [review]
remove the argument

I haven't tested this yet, but it compiles, so there shouldn't be a problem.  I'll try server it before I land it.
Attachment #559216 - Flags: review?(jorendorff)
Attachment #559216 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/932366760659

Comment 3

6 years ago
Try run for 51307568846d is complete.
Detailed breakdown of the results available here:
    http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=51307568846d
Results (out of 146 total builds):
    exception: 2
    success: 141
    warnings: 2
    failure: 1
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/amccreight@mozilla.com-51307568846d
http://hg.mozilla.org/mozilla-central/rev/932366760659
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
There is still no actual alliteration in this function, but I guess that's a separate bug.
You need to log in before you can comment on or make changes to this bug.