Closed Bug 685645 Opened 10 years ago Closed 9 years ago

make it clearer in splinter that a hunk's section/function header is not a removal

Categories

(bugzilla.mozilla.org :: Splinter, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: glob)

References

Details

(Whiteboard: [ateamtrack: p=bugzilla q=2013q2 m=3])

When reviewing this patch with Splinter, I noticed that it seemed to remove the "ku" line from l10n-changesets_mozilla-beta: https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=685253&attachment=559242

Upon closer inspection I noticed that there was no line number associated with that "removal", so I looked at the raw diff (https://bugzilla.mozilla.org/attachment.cgi?id=559242&action=edit) and noticed that the ku part was just extra context at the start of the hunk.

I'm pretty sure I've seen this with other diffs too.
Whiteboard: [ateamtrack: p=bugzilla q=2 m=3]
Whiteboard: [ateamtrack: p=bugzilla q=2 m=3] → [ateamtrack: p=bugzilla q=2013q2 m=3]
Assignee: nobody → glob
the line in question is:

@@ -48,28 +48,28 @@ ku 661c8de1dad2

the part after the second @@ is an optional section header; normally it's used to hold the name of the function this hunk is a part of.

both splinter and bugzilla's native diff viewer display this information differently from a normal diff -- this is why it has a different coloured background and is missing the line numbers.

i'm not sure why git/hg is putting the previous line there, however that you've (almost) confused it with a removal indicates that how splinter styles this isn't clear enough.

bugzilla's diff puts a border around the line and includes the line numbers.  i'll do the same for splinter.
Summary: splinter diff viewer gets confused by some diffs → make it clearer in splinter that a hunk's section/function header is not a removal
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/Splinter/web/splinter.css
modified extensions/Splinter/web/splinter.js
Committed revision 8786.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 885464
You need to log in before you can comment on or make changes to this bug.