685774 - Implement document.scripts

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

Firefox is the only browser which lacks a support for document.scripts.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is pretty simple to implement.  Do you want to take a shot at it?

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: patch

> This is pretty simple to implement.  Do you want to take a shot at it?
Yes, I'll take this bug.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 559490 [details] [diff] [review]
patch

>+++ b/dom/tests/mochitest/whatwg/test_bug685774_document_scripts.html
>+  is(a.length, c, "unexpected count of scripe elements");

s/scripe/script/

r=me with that typo fixed.  Thank you!

Comment 4

[Mounir Lamouri (:mounir)]

Comment on attachment 559490 [details] [diff] [review]
patch

Review of attachment 559490 [details] [diff] [review]:
-----------------------------------------------------------------

Could you name the test test_document_scripts.html instead (no need for the bug number)?

You could also do a test after calling:
document.createElement("script");
and another after adding this element to the DOM.

::: dom/tests/mochitest/whatwg/test_bug685774_document_scripts.html
@@ +36,5 @@
> +
> +  SimpleTest.finish();
> +}
> +
> +window.addEventListener('load', start, false);

Better to use addLoadEvent(start);

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: patch for check in

Fixed review comments.

Comment 6

[Justin Wood (:Callek)]

http://hg.mozilla.org/mozilla-central/rev/a739df5e7bc0

Comment 7

[Ryan Jones-Ward [:sciguyryan]]

Would this bug need the dev-doc-needed keyword marker?

Comment 8

[Masatoshi Kimura [:emk]]

Sure.

Comment 9

[Eric Shepherd [:sheppy]]

Documented:

https://developer.mozilla.org/en/DOM/Document.scripts

Updated:

https://developer.mozilla.org/en/DOM/Document
https://developer.mozilla.org/en/DOM/HTMLCollection

And mentioned on Firefox 9 for developers.