Last Comment Bug 685788 - Test for bug 593174 conceals its location after it's done
: Test for bug 593174 conceals its location after it's done
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla9
Assigned To: :Ehsan Akhgari
:
Mentors:
Depends on:
Blocks: 593174 668728
  Show dependency treegraph
 
Reported: 2011-09-08 21:56 PDT by :Ehsan Akhgari
Modified: 2011-09-23 20:48 PDT (History)
3 users (show)
ehsan: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (1.37 KB, patch)
2011-09-08 21:57 PDT, :Ehsan Akhgari
ted: review+
justin.lebar+bug: review+
Details | Diff | Splinter Review

Description :Ehsan Akhgari 2011-09-08 21:56:39 PDT
My patch in bug 668728 requires that when each test is finished, its location won't change.  The test for bug 593174 breaks this invariant, by using history.replaceState.  I have a simple patch to fix this.
Comment 1 :Ehsan Akhgari 2011-09-08 21:57:44 PDT
Created attachment 559385 [details] [diff] [review]
Patch (v1)
Comment 2 Ted Mielczarek [:ted.mielczarek] 2011-09-22 12:53:15 PDT
Comment on attachment 559385 [details] [diff] [review]
Patch (v1)

Review of attachment 559385 [details] [diff] [review]:
-----------------------------------------------------------------

This looks sane, but you'd probably be better off having the original test author review this.
Comment 3 Justin Lebar (not reading bugmail) 2011-09-22 20:21:43 PDT
(In reply to Ehsan Akhgari [:ehsan] from comment #0)
> My patch in bug 668728 requires that when each test is finished, its
> location won't change.

It's not a problem if the test fails (e.g. throws an exception) and leaves the location different than it was initially?
Comment 5 Ed Morley [:emorley] 2011-09-23 20:48:26 PDT
https://hg.mozilla.org/mozilla-central/rev/c53b5ca8fde3

Note You need to log in before you can comment on or make changes to this bug.