Remove the nsTableOuterFrame::mInnerTableFrame and mCaptionFrame members in favor of accessing the child frame lists directly

RESOLVED FIXED in mozilla9

Status

()

Core
Layout: Tables
--
enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

unspecified
mozilla9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Follow-up from bug 685154 comment 9 - 12

Remove the nsTableOuterFrame::mInnerTableFrame and mCaptionFrame members in favor of accessing the child frame lists directly.
At some point we're going to need to support multiple caption frames.  Hopefully this will help...
(Assignee)

Comment 2

6 years ago
Created attachment 559507 [details] [diff] [review]
fix

The accessor InnerTableFrame() is mostly to avoid having to cast it to
nsTableFrame* a lot. (without Get-prefix since it can't be null)

Replace mCaptionFrame with mCaptionFrames.FirstChild(), except
where it was used for (non-)null testing for which I used
mCaptionFrames.NotEmpty() or IsEmpty() instead.
Attachment #559507 - Flags: review?(roc)
(Assignee)

Comment 3

6 years ago
(the patch is to be applied on top of the patches in bug 685154)
Attachment #559507 - Flags: review?(roc) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/d49caeac648d
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
https://hg.mozilla.org/mozilla-central/rev/d49caeac648d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.