Closed Bug 685901 Opened 8 years ago Closed 8 years ago

Remove the nsTableOuterFrame::mInnerTableFrame and mCaptionFrame members in favor of accessing the child frame lists directly

Categories

(Core :: Layout: Tables, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: mats, Assigned: mats)

Details

Attachments

(1 file)

Follow-up from bug 685154 comment 9 - 12

Remove the nsTableOuterFrame::mInnerTableFrame and mCaptionFrame members in favor of accessing the child frame lists directly.
At some point we're going to need to support multiple caption frames.  Hopefully this will help...
Attached patch fixSplinter Review
The accessor InnerTableFrame() is mostly to avoid having to cast it to
nsTableFrame* a lot. (without Get-prefix since it can't be null)

Replace mCaptionFrame with mCaptionFrames.FirstChild(), except
where it was used for (non-)null testing for which I used
mCaptionFrames.NotEmpty() or IsEmpty() instead.
Attachment #559507 - Flags: review?(roc)
(the patch is to be applied on top of the patches in bug 685154)
http://hg.mozilla.org/integration/mozilla-inbound/rev/d49caeac648d
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
https://hg.mozilla.org/mozilla-central/rev/d49caeac648d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.