68591 - PSM not in IRIX binaries

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[John A. Turner]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; IRIX64 6.5 IP30; en-US; 0.8) Gecko/20010211
BuildID:    2001021121

msg in console is:

Error loading URL http://www.etrade.com/: 804b0002 
Error loading URL https://trading.etrade.com/cgi-bin/gx.cgi/AppLogic+Loginpage:
804b0033 


Reproducible: Always
Steps to Reproduce:
1. go to http://www.etrade.com/
2. click on yellow Login button


Actual Results:  Etrade home page stays up

Expected Results:  should have gone to login page

Comment 1

[Boris Zbarsky [:bzbarsky]]

Does the mozilla build you are using include PSM?  What happens if you go to
Tasks > Privacy and Security > Personal Security Manager (in the Mozilla menus)?

Comment 2

[John A. Turner]

nothing happens when I do Tasks -> P&S -> PSM, so I guess that means this build
doesn't include PSM, right?

I'm using the 2001-02-11 Irix nightly build...

Comment 3

[Boris Zbarsky [:bzbarsky]]

That would mean that the build does not include PSM, yes.  If you have the
option of building yourself, you may want to build with PSM...

Strange that the Irix builds on mozilla.org are not built with it.

Comment 4

[Keyser Sose]

Reporter have you been able to reproduce this problem?

Comment 5

[Brian 'netdragon' Bober]

Worksforme on build 2001022209 Windows 2000

Comment 6

[Brian 'netdragon' Bober]

Reporter, can you try getting a new build?

Comment 7

[Boris Zbarsky [:bzbarsky]]

OK.  Looks like PSM is just not in the current IRIX nightlies. Changing this bug
to be about that.  See also bug 67742. for possible related stuff.

Comment 8

[John A. Turner]

just to confirm, latest nightly Irix build was 2001-02-22-21, which
still apparently lacks PSM

I've attempted to build on Irix myself, but have been unsuccessful
thus far

Comment 9

[John Vandenberg]

I have been able to build and test IRIX6.5 with PSM on 0.8; however the changes 
that I have made dont seem to work on the the tree from a few days ago.  I am 
looking into it atm.

Comment 10

[John Vandenberg]

Attachment: Patch to build PSM1.x on 0.8

Comment 11

[John Vandenberg]

In order to build PSM1.x on Mozilla 0.8 on IRIX 6.5; I needed to set USE_N32 = 
1, and apply this patch to ctrlconn.c to add a declaration which it isnt 
getting out of nlslayer.h for some reason.
When testing it with a few https sites, it was _extremely_ slow, to the point 
of almost hanging.  I was able to get up a PSM notification that the above site 
was signed with a cert. that is out of date.

Comment 12

[John Vandenberg]

Using the instructions posted to n.p.m.crypto for building PSM2.0 Milestone 1.5 
against the latest trunk, I was able to get PSM2 to build after creating 
symbolic links from dist/IRIX6_mips_DBG.OBJ to dist/IRIX6.5_DBG.OBJ.  
IRIX6_mips_DBG.OBJ is created in the build process, however both are utilised, 
even in the same CC commands.

---
cd crmf; gmake libs
gmake[3]: Entering directory 
`/projects/sise/mozilla/devel/workpits/moz/latest_debug/workarea/security/nss/li
b/crmf'
cc -o IRIX6.5_DBG.OBJ/crmfenc.o -c -g -dollar -fullwarn -xansi -n32 -mips3 -
exceptions -DSVR4 -DIRIX  -multigot -D_SGI_MP_SOURCE -MDupdate 
IRIX6.5_DBG.OBJ/.md -DIRIX6_5 -mips3 -DXP_UNIX -DDEBUG -UNDEBUG -DDEBUG_johnv -
I../../../../dist/IRIX6.5_DBG.OBJ/include  -
I/projects/sise/mozilla/devel/workpits/moz/latest_debug/workarea/dist/IRIX6_mips
_DBG.OBJ/public/security -
I/projects/sise/mozilla/devel/workpits/moz/latest_debug/workarea/dist/IRIX6_mips
_DBG.OBJ/private/security -
I/projects/sise/mozilla/devel/workpits/moz/latest_debug/workarea/dist/IRIX6_mips
_DBG.OBJ/public/dbm  crmfenc.c
cc WARNING:  -I../../../../dist/IRIX6.5_DBG.OBJ/include does not refer to a 
valid directory
cc WARNING:  -
I/projects/sise/mozilla/devel/workpits/moz/latest_debug/workarea/dist/IRIX6_mips
_DBG.OBJ/public/dbm does not refer to a valid directory
cc-1005 cc: ERROR File 
= /projects/sise/mozilla/devel/workpits/moz/latest_debug/workarea/dist/IRIX6_mip
s_DBG.OBJ/public/security/seccomon.h, Line = 47
  The source file "prtypes.h" is unavailable.

  #include "prtypes.h"
                      ^

1 catastrophic error detected in the compilation of "crmfenc.c".
Compilation terminated.
---

Looking back at 0.8, and the patch I made yesterday, it would seem that 0.8 had 
the exact same problem.

After getting it to build, I tested it and it was usable (given PSM2 does not 
have everything implemented at the moment).

Moral of the story is the previous patch doesnt fix the real build problem but 
I am working on it.

Comment 13

[David P. Drinan]

PSM 2.0 is now part of the mozilla and commercial builds and has fixed alot of 
UI and ssl bugs that were in PSM 1.X. I'm doing a mass setting of bugs to 
be FIXED. If you believe that I've closed a bug in error, please re-open it. 
Thanks.

Comment 14

[Boris Zbarsky [:bzbarsky]]

reopening since it's not built by default yet

Comment 15

[David P. Drinan]

Changing product from Browser:Security:Crypto --> PSM 2.0

Comment 16

[John Vandenberg]

nor does it build using --enable-crypto ... but Im fixing that now.

Comment 17

[John Vandenberg]

I have provided a fix to NSS Autoconf in bug 77276

I have built and tested NSS Autoconf/PSM using --enable-crypto, so perhaps we 
are now ready to have PSM in IRIX builds now.

Comment 18

[Bob Lord]

-> 2.0, P3, ssaux

Comment 19

[John Mark Vandenberg]

SGI released builds (on oss.sgi.com/projects/mozilla) since 0.6 include PSM2, 
and last week we decided to have Browser+PSM as our base configuration for 
release builds.  

As bug 60912 (PSM on Linux) has been resolved, why is the IRIX build required 
to wait until 2.0 before PSM is enabled by default?

Comment 20

[Stephane Saux]

Mass reassigning target to 2.1

Comment 21

[Stephane Saux]

Moving all P3 and P4 bugs targetted to 2.1 to future.

Comment 22

[Stephane Saux]

removing nsenterprise keyword from PSM bugs with target milestone of future.

Comment 23

[John Mark Vandenberg]

The IRIX tarballs on http://ftp.mozilla.org/pub/mozilla/nightly/latest now have 
PSM included.  I believe this bug can now be closed.

Comment 24

[John Unruh]

Marking fixed.

Comment 25

[John Unruh]

Verified per johnv's comment.