Closed Bug 686003 Opened 13 years ago Closed 12 years ago

The test for bug 507902 navigates away from the page while it's in progress

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

I found this bug when I was working on bug 668728.  The solution here is simple: move the test to an internal iframe, so that the location change doesn't ruin what our test framework expects.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #559564 - Flags: review?(ted.mielczarek)
Comment on attachment 559564 [details] [diff] [review]
Patch (v1)

Review of attachment 559564 [details] [diff] [review]:
-----------------------------------------------------------------

This looks okay from my perspective, but you really should get the original test author to review it.

::: dom/tests/mochitest/orientation/Makefile.in
@@ +49,1 @@
>  		test_bug507902.html \

Can you fix this to be two-space indentation while you're here?

::: dom/tests/mochitest/orientation/test_bug507902.html
@@ +16,5 @@
>    window.addEventListener("devicemotion", function(){}, false);
>    location = "data:text/html,2";
>  
>    ok(1, "leak will be at the end of mochitests. so pass.");
>    SimpleTest.finish();

If this isn't being used here, please just remove it.
Attachment #559564 - Flags: review?(ted.mielczarek) → review+
Attachment #559564 - Flags: review?(doug.turner)
Comment on attachment 559564 [details] [diff] [review]
Patch (v1)

Review of attachment 559564 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/mochitest/orientation/test_bug507902.html
@@ +3,2 @@
>  <head>
> +  <title>Frame for watchPosition </title>

Might as well change the title of this when you're here.

@@ +16,5 @@
>    window.addEventListener("devicemotion", function(){}, false);
>    location = "data:text/html,2";
>  
>    ok(1, "leak will be at the end of mochitests. so pass.");
>    SimpleTest.finish();

if you don't need, please remove.
Attachment #559564 - Flags: review?(doug.turner) → review+
https://hg.mozilla.org/mozilla-central/rev/11c676ef0718
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.