The test for bug 507902 navigates away from the page while it's in progress

RESOLVED FIXED in mozilla12

Status

()

Core
Layout: Images
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla12
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
I found this bug when I was working on bug 668728.  The solution here is simple: move the test to an internal iframe, so that the location change doesn't ruin what our test framework expects.
(Assignee)

Comment 1

6 years ago
Created attachment 559564 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #559564 - Flags: review?(ted.mielczarek)
Comment on attachment 559564 [details] [diff] [review]
Patch (v1)

Review of attachment 559564 [details] [diff] [review]:
-----------------------------------------------------------------

This looks okay from my perspective, but you really should get the original test author to review it.

::: dom/tests/mochitest/orientation/Makefile.in
@@ +49,1 @@
>  		test_bug507902.html \

Can you fix this to be two-space indentation while you're here?

::: dom/tests/mochitest/orientation/test_bug507902.html
@@ +16,5 @@
>    window.addEventListener("devicemotion", function(){}, false);
>    location = "data:text/html,2";
>  
>    ok(1, "leak will be at the end of mochitests. so pass.");
>    SimpleTest.finish();

If this isn't being used here, please just remove it.
Attachment #559564 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

6 years ago
Attachment #559564 - Flags: review?(doug.turner)

Comment 3

6 years ago
Comment on attachment 559564 [details] [diff] [review]
Patch (v1)

Review of attachment 559564 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/mochitest/orientation/test_bug507902.html
@@ +3,2 @@
>  <head>
> +  <title>Frame for watchPosition </title>

Might as well change the title of this when you're here.

@@ +16,5 @@
>    window.addEventListener("devicemotion", function(){}, false);
>    location = "data:text/html,2";
>  
>    ok(1, "leak will be at the end of mochitests. so pass.");
>    SimpleTest.finish();

if you don't need, please remove.
Attachment #559564 - Flags: review?(doug.turner) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/11c676ef0718
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/11c676ef0718
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.