686133 - Bugzilla crashes when deleting a bug

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Frédéric Buclin]

Attachment: patch, v1

When deleting a bug, you get:

Can't locate object method "DESTROY" via package "Bugzilla::Bug" at Bugzilla/Bug.pm line 1134.

This is working fine in 4.0 and older. I suspect this is due to the removal of Bugzilla::Bug::AUTOLOAD in bug 600123.

Thanks to our QA scripts for finding this bug. \o/

Comment 1

[Tiago Mello [:timello]]

Comment on attachment 559702 [details] [diff] [review]
patch, v1

I think you should 'undef $self' before returning it, shouldn't you?

Comment 2

[Frédéric Buclin]

Attachment: patch for 5.0, v2

For 5.0, rely on foreign keys to delete all references to the bug being deleted. For 4.2, I will attach a much less invasive patch, based on timello's suggestion.

Comment 3

[Frédéric Buclin]

Attachment: patch for 4.2, v2

Comment 4

[Tiago Mello [:timello]]

Comment on attachment 559719 [details] [diff] [review]
patch for 4.2, v2

Review of attachment 559719 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good!

Comment 5

[Tiago Mello [:timello]]

Comment on attachment 559718 [details] [diff] [review]
patch for 5.0, v2

Review of attachment 559718 [details] [diff] [review]:
-----------------------------------------------------------------

::: Bugzilla/Bug.pm
@@ +1091,3 @@
>  
>      my $bug_id = $self->{'bug_id'};
> +    $self->SUPER::remove_from_db();

I think we should start a transaction before calling SUPER::remove_from_db and close it after we delete bug_fulltext.

Comment 6

[Frédéric Buclin]

Comment on attachment 559718 [details] [diff] [review]
patch for 5.0, v2

No, SUPER::remove_from_db() already starts the transaction for us, and MySQL tables do not support transactions.

Comment 7

[Frédéric Buclin]

(In reply to Frédéric Buclin from comment #6)
> MySQL tables do not support transactions.

I meant MyISAM tables.

Comment 8

[Tiago Mello [:timello]]

Comment on attachment 559718 [details] [diff] [review]
patch for 5.0, v2

Review of attachment 559718 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup!

Comment 9

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Bug.pm
Committed revision 7956.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified Bugzilla/Bug.pm
Committed revision 7924.