686138 - Update Growl framework to 1.2.2

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Mitch]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_1) AppleWebKit/534.48.3 (KHTML, like Gecko) Version/5.1 Safari/534.48.3

Steps to reproduce:

The Growl developers say Growl will break with the release of 1.3 for apps not updated to at least the 1.2.2 framework.

http://groups.google.com/group/growldiscuss/browse_thread/thread/1bf5b4c50375458

Comment 1

[Stuart Morgan]

I'll take a look at this; hopefully they haven't made 10.4 compat any worse from a build standpoint.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

They claim on that anything newer than 1.1.6  requires Xcode 3 to build and 10.5 to run, whereas we still support both Xcode 2.5 to build and 10.4 to run :(

However, it looks like we're using 1.2+ with a bunch of local build-related changes[1], so hopefully it's nothing more than replicating those again in 1.2.2.

[1] http://mxr.mozilla.org/camino/source/camino/growl/README

Thanks for looking at this, Stuart; I'm definitely not in the right frame of mind to untangle this this time ;)

Comment 3

[Stuart Morgan]

Right, that's my hope. I'll look very carefully at the diff relative to our current snapshot.

Comment 4

[Stuart Morgan]

Attachment: Update to 1.2.2

Hopefully this will do it. I updated the source, and manually patched in each project change one piece at a time (since mostly it was file additions and test-target additions, so doing that seemed less error-prone than re-doing our local changes).

It looks from the project file like even at 1.2.2, the Growl frameworks target 10.4 as a deployment target for 32-bit, they just don't use the 10.4 SDK. That means it's very likely that since this compiles for me with the 10.4 (after one local change to basically no-op-ify NSMakeCollectable, which is fine since it doesn't do anything except in a GC build anyway), it will run on 10.4. I.e., there shouldn't be any sneaky this-will-build-for-10.4-but-crash-when-run-there bugs.

That said, I don't have 10.4, nor do I have Growl, so who knows if this actually works ;) I'll land it when I have time, and then we can try to find someone to test a nightly on 10.4.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Stuart, if you don't have time to land this Monday, should I land it for you Monday evening?

I've built this debug and release, but like you I'm not on 10.4 nor do I have Growl.

Comment 6

[Eiichi]

(In reply to Stuart Morgan from comment #4)
> That said, I don't have 10.4, nor do I have Growl, so who knows if this
> actually works ;) I'll land it when I have time, and then we can try to find
> someone to test a nightly on 10.4.

I tried to build Camino applied a patch and tested it after installing Growl on 10.4.
It works as expected on intel, but don't know on ppc.

Comment 7

[Stuart Morgan]

> It works as expected on intel, but don't know on ppc.

There's no reason it should be any different (arch-specific build rules are all commented out since our toolchain doesn't support them), so it should work there too. Thanks for testing!

> Stuart, if you don't have time to land this Monday, should I land it for you

Yep, sounds good. If I don't get to it this evening my time, feel free to land it in your evening :)

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/99a8adfc4279 with r=ardissone, since I did inspect said patch ;-)

Comment 9

[Stuart Morgan]

Awesome, thanks!