Closed
Bug 686227
Opened 13 years ago
Closed 13 years ago
Users with editcomponents privs must be able to add products they cannot see to the inclusion and exclusion lists when creating or editing a flagtype
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.2
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.44 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
In Bugzilla 4.0 and older, a user with editcomponents privs could add any product to the inclusion and exclusion lists when creating or editing a flagtype. In 4.2, I inadvertently restricted the ability to include products you can see only while working on bug 529974 (because I had users with local editcomponents privs in mind). I must relax this to the way it worked in Bugzilla 4.0 and older.
Nice catch by our QA scripts. :)
Flags: blocking4.2+
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #559785 -
Flags: review?(glob)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #559785 -
Flags: review?(glob) → review?(dkl)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 559785 [details] [diff] [review]
patch, v1
Review of attachment 559785 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good and works as expected. r=dkl
Attachment #559785 -
Flags: review?(dkl) → review+
|
|
Assignee | |
Updated•13 years ago
|
Flags: approval4.2+
Flags: approval+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/FlagType.pm
Committed revision 7960.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified Bugzilla/FlagType.pm
Committed revision 7928.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•