Last Comment Bug 686257 - nsMenuPopupFrame.cpp:149:18: warning: unused variable 'presContext'
: nsMenuPopupFrame.cpp:149:18: warning: unused variable 'presContext'
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla9
Assigned To: Daniel Holbert [:dholbert]
:
: Jet Villegas (:jet)
Mentors:
http://tinderbox.mozilla.org/showlog....
Depends on:
Blocks: buildwarning 669028
  Show dependency treegraph
 
Reported: 2011-09-11 20:11 PDT by Daniel Holbert [:dholbert]
Modified: 2011-09-12 06:49 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix: remove unused variable (1.05 KB, patch)
2011-09-11 20:12 PDT, Daniel Holbert [:dholbert]
masayuki: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2011-09-11 20:11:41 PDT
Bug 669028 removed the last usage of the local-var |presContext| in nsMenuPopupFrame::Init, triggering:
{
layout/xul/base/src/nsMenuPopupFrame.cpp: In member function 'virtual nsresult nsMenuPopupFrame::Init(nsIContent*, nsIFrame*, nsIFrame*)':
layout/xul/base/src/nsMenuPopupFrame.cpp:149:18: warning: unused variable 'presContext'
}

Upcoming attached patch removes this variable, fixing the warning.
Comment 1 Daniel Holbert [:dholbert] 2011-09-11 20:12:53 PDT
Created attachment 559815 [details] [diff] [review]
fix: remove unused variable
Comment 2 Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-09-11 20:35:04 PDT
Comment on attachment 559815 [details] [diff] [review]
fix: remove unused variable

Thank you!
Comment 3 Daniel Holbert [:dholbert] 2011-09-11 20:54:24 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/cdf7e50630fc

Note You need to log in before you can comment on or make changes to this bug.