686259 - Upgrade to Flashblock 1.5.15

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Flashblock 1.5.15 came out this summer.  We should probably sync 2.1 with it.

Of the fixes, only "NS_ERROR_DOM_NOT_FOUND_ERR in flashblockShowFlash()" appears to apply to us (we already were doing the whitelisting method from https://www.mozdev.org/bugs/show_bug.cgi?id=23456 AFAICT; see bug 508630, which wanted us to adopt the now-former Flashblock logic.  We also already shipped the new placeholder images since bug 614485).

Philip, could you provide some detail about what the "NS_ERROR_DOM_NOT_FOUND_ERR in flashblockShowFlash()" problem was?

Comment 1

[Philip Chee]

We save a reference to the parent of the original flash and then replace that flash with our placeholder, later we then use that reference to replace the placeholder with the original flash. Unfortunately with AJAX pages, the DOM can be rewritten while our placeholder is active and the parent reference is now stale. So now we ignore the cached reference and explicitly locate the current parent of the placeholder.

Any AJAX page that uses document.write() or .innerHTML has the potential to mess us up. So this fix isn't perfect but it seems to have fixed a lot of long standing annoyances where clicking on the placeholder fails to reactivate the Flash.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Ah, thanks, Philip!  Can you remember any specific sites/testcases offhand?

That fix (and thus our upgrade) is just 2 lines in flashblock.xml[1] (plus the flashblock/README update), so I'll look at it tomorrow if no-one beats me to it.

[1] http://www.mozdev.org/source/browse/flashblock/source/content/flashblock/flashblock.xml.diff?r1=1.8.2.47;r2=1.8.2.48;only_with_tag=FLASHBLOCK_1_5_CLEANUP_BRANCH;f=h

Comment 3

[Philip Chee]

> Ah, thanks, Philip!  Can you remember any specific sites/testcases offhand?
Ulp. My gmail search-fu as well as my wetware memory both fail to find the problematic sites. Sorry.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Upgrade to 1.5.15

(In reply to Philip Chee from comment #3)
> > Ah, thanks, Philip!  Can you remember any specific sites/testcases offhand?
> Ulp. My gmail search-fu as well as my wetware memory both fail to find the
> problematic sites. Sorry.

No worries.

This patch has been lightly tested ("Flashblock still works!"), but it's just porting code that has been shipped in Flashblock-the-extension since July, so…

Comment 5

[Stuart Morgan]

Comment on attachment 559934 [details] [diff] [review]
Upgrade to 1.5.15

sr=smorgan

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/33b1538f111a

We can look at this for 2.0.10 if we get there.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #6)
> We can look at this for 2.0.10 if we get there.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Smokey Ardisson (back-ish; no bugmail - do not email) from comment #7)
> (In reply to comment #6)
> > We can look at this for 2.0.10 if we get there.

2.0.x is gone.