Closed
Bug 686279
Opened 14 years ago
Closed 14 years ago
Fix GCC 4.6 warnings in js/src
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: igor, Assigned: igor)
Details
Attachments
(1 file)
|
3.76 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
GCC 4.6 reports few set-but-unused warnings uder js/src. The attached patch fixes that.
Attachment #559833 -
Flags: review?(luke)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 559833 [details] [diff] [review]
v1
Review of attachment 559833 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jsemit.cpp
@@ +4376,5 @@
> * in the containing scope, and puts x in the loop body's scope.
> */
> +#ifdef DEBUG
> + bool let = (pn->pn_op == JSOP_NOP);
> +#endif
DebugOnly<bool> let = ...;
Attachment #559833 -
Flags: review?(luke) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/f350135d6b10 - pushed with DebugOnly change in jsemit.cpp and with couple of extra DebugOnly changes in jslock.cpp that I missed in v1. With that the only warnings from js/src come from valgring macros.
|
||
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•