Closed Bug 686279 Opened 8 years ago Closed 8 years ago

Fix GCC 4.6 warnings in js/src

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: igor, Assigned: igor)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
GCC 4.6 reports few set-but-unused warnings uder js/src. The attached patch fixes that.
Attachment #559833 - Flags: review?(luke)
Comment on attachment 559833 [details] [diff] [review]
v1

Review of attachment 559833 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsemit.cpp
@@ +4376,5 @@
>       * in the containing scope, and puts x in the loop body's scope.
>       */
> +#ifdef DEBUG
> +    bool let = (pn->pn_op == JSOP_NOP);
> +#endif

DebugOnly<bool> let = ...;
Attachment #559833 - Flags: review?(luke) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/f350135d6b10 - pushed with DebugOnly change in jsemit.cpp and with couple of extra DebugOnly changes in jslock.cpp that I missed in v1. With that the only warnings from js/src come from valgring macros.
https://hg.mozilla.org/mozilla-central/rev/f350135d6b10
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.