Last Comment Bug 686279 - Fix GCC 4.6 warnings in js/src
: Fix GCC 4.6 warnings in js/src
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla9
Assigned To: Igor Bukanov
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-12 01:09 PDT by Igor Bukanov
Modified: 2011-09-13 06:45 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (3.76 KB, patch)
2011-09-12 01:09 PDT, Igor Bukanov
luke: review+
Details | Diff | Splinter Review

Description Igor Bukanov 2011-09-12 01:09:09 PDT
Created attachment 559833 [details] [diff] [review]
v1

GCC 4.6 reports few set-but-unused warnings uder js/src. The attached patch fixes that.
Comment 1 Luke Wagner [:luke] 2011-09-12 08:15:29 PDT
Comment on attachment 559833 [details] [diff] [review]
v1

Review of attachment 559833 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsemit.cpp
@@ +4376,5 @@
>       * in the containing scope, and puts x in the loop body's scope.
>       */
> +#ifdef DEBUG
> +    bool let = (pn->pn_op == JSOP_NOP);
> +#endif

DebugOnly<bool> let = ...;
Comment 2 Igor Bukanov 2011-09-12 11:15:12 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/f350135d6b10 - pushed with DebugOnly change in jsemit.cpp and with couple of extra DebugOnly changes in jslock.cpp that I missed in v1. With that the only warnings from js/src come from valgring macros.
Comment 3 Matt Brubeck (:mbrubeck) 2011-09-13 06:45:05 PDT
https://hg.mozilla.org/mozilla-central/rev/f350135d6b10

Note You need to log in before you can comment on or make changes to this bug.