Closed Bug 686371 Opened 9 years ago Closed 8 years ago

Fix pixman compilation for iOS

Categories

(Core :: Graphics, defect)

ARM
iOS 4
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: ted, Assigned: ted)

Details

(Whiteboard: [iOS] fixed-in-bs)

Attachments

(1 file)

Currently Apple's assembler can't handle the ARM assembly pixman has. I have a patch that makes us use the C fallbacks, but that seems like a crummy way to go. I'm sure the actual assembly code works fine, it would just need to be massaged to make Apple as happy.
Here's the patch to use the C fallback. It's not great, but it's the easiest thing to start with.
Assignee: nobody → ted.mielczarek
Comment on attachment 559906 [details] [diff] [review]
Use C fallback on iOS

Jeff and I talked about this yesterday, this is the easiest solution for now. Once clang's ARM/iOS assembler is in a better state, we'll revisit this.
Attachment #559906 - Flags: review?(jmuizelaar)
Comment on attachment 559906 [details] [diff] [review]
Use C fallback on iOS

Please add a comment about why, so that it's easy to take this out in the future.
Attachment #559906 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/7641937ce773
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.