Closed
Bug 686371
Opened 14 years ago
Closed 14 years ago
Fix pixman compilation for iOS
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: ted, Assigned: ted)
Details
(Whiteboard: [iOS] fixed-in-bs)
Attachments
(1 file)
|
941 bytes,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Currently Apple's assembler can't handle the ARM assembly pixman has. I have a patch that makes us use the C fallbacks, but that seems like a crummy way to go. I'm sure the actual assembly code works fine, it would just need to be massaged to make Apple as happy.
|
Assignee | |
Comment 1•14 years ago
|
||
Here's the patch to use the C fallback. It's not great, but it's the easiest thing to start with.
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → ted.mielczarek
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 559906 [details] [diff] [review]
Use C fallback on iOS
Jeff and I talked about this yesterday, this is the easiest solution for now. Once clang's ARM/iOS assembler is in a better state, we'll revisit this.
Attachment #559906 -
Flags: review?(jmuizelaar)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 559906 [details] [diff] [review]
Use C fallback on iOS
Please add a comment about why, so that it's easy to take this out in the future.
Attachment #559906 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Whiteboard: [iOS] → [iOS] fixed-in-bs
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•